Skip to content

Commit

Permalink
git: update to 2.36.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@herbygillot
herbygillot committed Apr 18, 2022
1 parent 620bec5 commit ce4020d
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions devel/git/Portfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ PortSystem 1.0
PortGroup perl5 1.0

name git
version 2.35.3
version 2.36.0
revision 0

description A fast version control system
Expand All @@ -25,13 +25,13 @@ distfiles git-${version}${extract.suffix} \
git-manpages-${version}${extract.suffix}

checksums git-${version}${extract.suffix} \
rmd160 3fac34c765e695b3090d9544a6a940f336fbfd60 \
sha256 15e9db4f9bf2ed9fff30cb62a00c5c7c0901015f5ab048cdb4e8b04ddee00fa2 \
size 6876328 \
rmd160 6503793060edcde4452745ddc93fa94abcd291a9 \
sha256 af5ebfc1658464f5d0d45a2bfd884c935fb607a10cc021d95bc80778861cc1d3 \
size 7003024 \
git-manpages-${version}${extract.suffix} \
rmd160 cd4c0bc4c7742ad442ad3e6ac00b3481b530eb55 \
sha256 a78c7ee00731cfa903fdf17e3af472c6413c1e014cedd771f6d29932def1e324 \
size 497672
rmd160 b21dee1e70ce580453b09985154ca5ec9fe75a94 \
sha256 c063c30e3d712865f1057c50f4b736b8ccab4bb542ca1c3b157d45e5ad61db5c \
size 503604

perl5.require_variant false
perl5.conflict_variants yes
Expand Down Expand Up @@ -167,9 +167,9 @@ variant pcre description {Use pcre} {
variant doc description {Install HTML and plaintext documentation} {
distfiles-append git-htmldocs-${version}${extract.suffix}
checksums-append git-htmldocs-${version}${extract.suffix} \
rmd160 298343ad4a37480a1aa839e55789cca73eda0ec6 \
sha256 1233694e22c452278b93494b722415820db16880b66a7e00f3633ff41e71dad1 \
size 1411664
rmd160 e73cf4db0539e09870fc08dcd7a7f8cec6cc93ef \
sha256 acc3e2a3c7c253ee48f82c9a73b5556618f89b518752a8984b7e44d7bcf91be9 \
size 1426148

patchfiles-append patch-git-subtree.html.diff

Expand Down

24 comments on commit ce4020d

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herbygillot Looks like it is broken now:

Undefined symbols:
  "_arc4random_buf", referenced from:
      _csprng_bytes in libgit.a(wrapper.o)
      _git_mkstemps_mode in libgit.a(wrapper.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [git-daemon] Error 1
make: *** Waiting for unfinished jobs....
Undefined symbols:
  "_arc4random_buf", referenced from:
      _csprng_bytes in libgit.a(wrapper.o)
      _git_mkstemps_mode in libgit.a(wrapper.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [git-http-backend] Error 1
Undefined symbols:
  "_arc4random_buf", referenced from:
      _csprng_bytes in libgit.a(wrapper.o)
      _git_mkstemps_mode in libgit.a(wrapper.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [git-imap-send] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work/git-2.36.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work/git-2.36.0" && /usr/bin/make -j4 -w all CFLAGS="-Os -std=gnu99 -arch ppc" LDFLAGS="-L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc" CC=/usr/bin/gcc-4.2 prefix=/opt/local CURLDIR=/opt/local ICONVDIR=/opt/local NO_FINK=1 NO_DARWIN_PORTS=1 NO_R_TO_GCC_LINKER=1 V=1 PERL_PATH="/opt/local/bin/perl5.28" NO_PERL_CPAN_FALLBACK=1 LIBPCREDIR=/opt/local USE_LIBPCRE2=1 
Exit code: 2

This will fix the missing symbol problem:

PortGroup           legacysupport 1.1
legacysupport.newest_darwin_requires_legacy 10

Then, however, it still fails, at least for me:

sh: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work/destroot/opt/local/share/git-gui/lib/Git Gui.app/Contents/MacOS/Wish: No such file or directory
Command failed: echo exec wish "'/opt/local/share/git-gui/lib/Git Gui.app/Contents/Resources/Scripts/AppMain.tcl'" '"$@"' >  '/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work/destroot/opt/local/share/git-gui/lib/Git Gui.app/Contents/MacOS/Wish'
Exit code: 1
Error: Failed to destroot git: command execution failed

Removing the echo line from Portfile allows the port to install.

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herbygillot @kencu @evanmiller Besides, I wanted to request an advice re git long back but had no convenient chance: I have a weird problem with its extraction on 10A190. I know this is not supported system, and I am not asking to do anything for my case on the port level. I will fix it locally for myself (and share the fix on Macrumors), but I cannot understand what goes wrong. This is literally the only port which fails to extract properly. (And I have to reboot to 10.5.8 to extract it and copy into 10.6.) This problem is not specific to this update, it has been in place for all the time I use 10A190.

--->  Extracting git-2.36.0.tar.xz
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work" && /opt/local/bin/xz -dc '/opt/local/var/macports/distfiles/git/git-2.36.0.tar.xz' | /usr/bin/gnutar --no-same-owner -xf - 
--->  Extracting git-manpages-2.36.0.tar.xz
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work" && /opt/local/bin/xz -dc '/opt/local/var/macports/distfiles/git/git-manpages-2.36.0.tar.xz' | /usr/bin/gnutar --no-same-owner -xf - 
/usr/bin/gnutar: .: Cannot utime: Permission denied
/usr/bin/gnutar: .: Cannot change mode to rwxrwxr-x: Permission denied
/usr/bin/gnutar: Error exit delayed from previous errors
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work" && /opt/local/bin/xz -dc '/opt/local/var/macports/distfiles/git/git-manpages-2.36.0.tar.xz' | /usr/bin/gnutar --no-same-owner -xf - 
Exit code: 2
Error: Failed to extract git: command execution failed

Why it cannot extract html docs folder?

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget why that happens, if I ever knew, but I saw that same error last year. As I recall I just installed git -doc and moved on, not bothering to sort it out as I just didn't care that much.

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kencu Got it, thanks. Yeah, it is survivable, just annoying for updates.

@herbygillot Extraction failure is specific to 10.6 PPC, but the missing symbol issue plagues all old systems. I have just tried to build it on Tiger, and it failed with the same error.

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure of git on 10.4.11:

/opt/local/bin/gcc-apple-4.2 -o reftable/writer.o -c     -Os -std=gnu99 -arch ppc -I. -DPRECOMPOSE_UNICODE -DPROTECT_HFS_DEFAULT=1 -DGIT_HOST_CPU="\"Power\"" -DUSE_LIBPCRE2 -I/opt/local/include -I/opt/local/include -DUSE_CURL_FOR_IMAP_SEND -I/opt/local/include -DUSE_ST_TIMESPEC -DSUPPORTS_SIMPLE_IPC -DOLD_ICONV -DSHA1_DC -DSHA1DC_NO_STANDARD_INCLUDES -DSHA1DC_INIT_SAFE_HASH_DEFAULT=0 -DSHA1DC_CUSTOM_INCLUDE_SHA1_C="\"cache.h\"" -DSHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C="\"git-compat-util.h\"" -DSHA256_BLK  -DHAVE_DEV_TTY -DHAVE_BSD_SYSCTL -DHAVE_ARC4RANDOM -DHAVE_NS_GET_EXECUTABLE_PATH  -DFREAD_READS_DIRECTORIES -DNO_MEMMEM -Icompat/regex -DHAVE_FSMONITOR_DAEMON_BACKEND -DSHELL_PATH='"/bin/sh"'  reftable/writer.c
rm -f reftable/libreftable.a && ar rcs reftable/libreftable.a reftable/basics.o reftable/error.o reftable/block.o reftable/blocksource.o reftable/iter.o reftable/publicbasics.o reftable/merged.o reftable/pq.o reftable/reader.o reftable/record.o reftable/refname.o reftable/generic.o reftable/stack.o reftable/tree.o reftable/writer.o
/opt/local/bin/gcc-apple-4.2   -Os -std=gnu99 -arch ppc -I. -DPRECOMPOSE_UNICODE -DPROTECT_HFS_DEFAULT=1 -DGIT_HOST_CPU="\"Power\"" -DUSE_LIBPCRE2 -I/opt/local/include -I/opt/local/include -DUSE_CURL_FOR_IMAP_SEND -I/opt/local/include -DUSE_ST_TIMESPEC -DSUPPORTS_SIMPLE_IPC -DOLD_ICONV -DSHA1_DC -DSHA1DC_NO_STANDARD_INCLUDES -DSHA1DC_INIT_SAFE_HASH_DEFAULT=0 -DSHA1DC_CUSTOM_INCLUDE_SHA1_C="\"cache.h\"" -DSHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C="\"git-compat-util.h\"" -DSHA256_BLK  -DHAVE_DEV_TTY -DHAVE_BSD_SYSCTL -DHAVE_ARC4RANDOM -DHAVE_NS_GET_EXECUTABLE_PATH  -DFREAD_READS_DIRECTORIES -DNO_MEMMEM -Icompat/regex -DHAVE_FSMONITOR_DAEMON_BACKEND -DSHELL_PATH='"/bin/sh"' -o git-daemon -L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc  -framework CoreServices daemon.o common-main.o libgit.a xdiff/lib.a reftable/libreftable.a libgit.a  -lpcre2-8 -L/opt/local/lib -R/opt/local/lib -lz -L/opt/local/lib -R/opt/local/lib -liconv -lintl 
ld: warning: duplicate dylib /opt/local/lib/libz.1.dylib
Undefined symbols:
  "_arc4random_buf", referenced from:
      _csprng_bytes in libgit.a(wrapper.o)
      _git_mkstemps_mode in libgit.a(wrapper.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [git-daemon] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work/git-2.36.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_git/git/work/git-2.36.0" && /usr/bin/make -j1 -w all CFLAGS="-Os -std=gnu99 -arch ppc" LDFLAGS="-L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc" CC=/opt/local/bin/gcc-apple-4.2 prefix=/opt/local CURLDIR=/opt/local ICONVDIR=/opt/local NO_FINK=1 NO_DARWIN_PORTS=1 NO_R_TO_GCC_LINKER=1 V=1 PERL_PATH="/opt/local/bin/perl5.28" NO_PERL_CPAN_FALLBACK=1 NO_APPLE_COMMON_CRYPTO=1 CC_LD_DYNPATH=-R LIBPCREDIR=/opt/local USE_LIBPCRE2=1 
Exit code: 2

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arc4random_buf is in legacysupport

https://github.com/macports/macports-legacy-support/blob/780d2b010b9e3443dcb42c1438b9fe2a5f94a69c/src/arc4random.c#L493

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie, like so many other of these, just add

PortGroup legacysupport 1.1

and it will probably work, as it does 99% of the time.

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kencu Got it, thanks. Yeah, it is survivable, just annoying for updates.

once you install git -doc, your updates will forever and ever follow that, so you will never come across it again.

No more annoyance!

@barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented on ce4020d Apr 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie, like so many other of these, just add

PortGroup legacysupport 1.1

and it will probably work, as it does 99% of the time.

@kencu Yes, I have in fact suggested the same above: ce4020d#commitcomment-71559796
But it has to be fixed in portfile, not for me locally. This failure is not specific to 10.6 PPC.

And then, there is another error on destroot.

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie, like so many other of these, just add

PortGroup legacysupport 1.1

and it will probably work, as it does 99% of the time.

@kencu Yes, I have in fact suggested the same above: ce4020d#commitcomment-71559796

did it not work, then? You keep posting the same error, so I presumed you must not have tried it.

There is another error on destroot though.

Oh, haven't seen that one as yet.

Edit: OK, so I went back and read your first post, where the arc4random_buf problem was fixed by adding legacysupport. So no need to point that error out any further, we just need to PR that. Whatever is going on in the destrooting is something else it appears.

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought that instead of making a separate PR asking @herbygillot to add required fix will be easier/faster.

Destroot problem appeared with the last two updates, it was not occurring before. But I am yet to check if it shows up on all PPC systems or not.

@herbygillot
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kencu @barracuda156 - I added the legacysupport portgroup in the commit here: 0c9bd9d

10.6 is still failing to build with the following:

DNO_MEMMEM -Icompat/regex -DHAVE_FSMONITOR_DAEMON_BACKEND -DSHELL_PATH='"/bin/sh"'  xdiff/xmerge.c
compat/fsmonitor/fsm-listen-darwin.c:72:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemChangeOwner'; did you mean 'kFSEventStreamEventFlagRootChanged'?
        if (flag & kFSEventStreamEventFlagItemChangeOwner)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagRootChanged
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:344:3: note: 'kFSEventStreamEventFlagRootChanged' declared here
  kFSEventStreamEventFlagRootChanged = 0x00000020,
  ^
compat/fsmonitor/fsm-listen-darwin.c:74:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemCreated'; did you mean 'kFSEventStreamEventFlagUserDropped'?
        if (flag & kFSEventStreamEventFlagItemCreated)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagUserDropped
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:309:3: note: 'kFSEventStreamEventFlagUserDropped' declared here
  kFSEventStreamEventFlagUserDropped = 0x00000002,
  ^
compat/fsmonitor/fsm-listen-darwin.c:76:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemFinderInfoMod'; did you mean 'kFSEventStreamEventFlagKernelDropped'?
        if (flag & kFSEventStreamEventFlagItemFinderInfoMod)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagKernelDropped
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:310:3: note: 'kFSEventStreamEventFlagKernelDropped' declared here
  kFSEventStreamEventFlagKernelDropped = 0x00000004,
  ^
compat/fsmonitor/fsm-listen-darwin.c:78:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemInodeMetaMod'; did you mean 'kFSEventStreamEventFlagUserDropped'?
        if (flag & kFSEventStreamEventFlagItemInodeMetaMod)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagUserDropped
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:309:3: note: 'kFSEventStreamEventFlagUserDropped' declared here
  kFSEventStreamEventFlagUserDropped = 0x00000002,
  ^
compat/fsmonitor/fsm-listen-darwin.c:80:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemIsDir'; did you mean 'kFSEventStreamEventFlagUnmount'?
        if (flag & kFSEventStreamEventFlagItemIsDir)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagUnmount
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:372:3: note: 'kFSEventStreamEventFlagUnmount' declared here
  kFSEventStreamEventFlagUnmount = 0x00000080
  ^
compat/fsmonitor/fsm-listen-darwin.c:82:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemIsFile'
        if (flag & kFSEventStreamEventFlagItemIsFile)
                   ^
compat/fsmonitor/fsm-listen-darwin.c:84:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemIsHardlink'; did you mean 'kFSEventStreamEventFlagHistoryDone'?
        if (flag & kFSEventStreamEventFlagItemIsHardlink)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagHistoryDone
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:331:3: note: 'kFSEventStreamEventFlagHistoryDone' declared here
  kFSEventStreamEventFlagHistoryDone = 0x00000010,
  ^
compat/fsmonitor/fsm-listen-darwin.c:86:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemIsLastHardlink'; did you mean 'kFSEventStreamEventFlagHistoryDone'?
        if (flag & kFSEventStreamEventFlagItemIsLastHardlink)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagHistoryDone
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:331:3: note: 'kFSEventStreamEventFlagHistoryDone' declared here
  kFSEventStreamEventFlagHistoryDone = 0x00000010,
  ^
compat/fsmonitor/fsm-listen-darwin.c:88:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemIsSymlink'
        if (flag & kFSEventStreamEventFlagItemIsSymlink)
                   ^
compat/fsmonitor/fsm-listen-darwin.c:90:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemModified'; did you mean 'kFSEventStreamEventFlagUserDropped'?
        if (flag & kFSEventStreamEventFlagItemModified)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   kFSEventStreamEventFlagUserDropped
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:309:3: note: 'kFSEventStreamEventFlagUserDropped' declared here
  kFSEventStreamEventFlagUserDropped = 0x00000002,
  ^
compat/fsmonitor/fsm-listen-darwin.c:92:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemRemoved'
        if (flag & kFSEventStreamEventFlagItemRemoved)
                   ^
compat/fsmonitor/fsm-listen-darwin.c:94:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemRenamed'
        if (flag & kFSEventStreamEventFlagItemRenamed)
                   ^
compat/fsmonitor/fsm-listen-darwin.c:96:13: error: use of undeclared identifier 'kFSEventStreamEventFlagItemXattrMod'
        if (flag & kFSEventStreamEventFlagItemXattrMod)

Full log here: https://build.macports.org/builders/ports-10.6_i386-builder/builds/66224/steps/install-port/logs/stdio

@evanmiller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destroot error is a new Tiger problem resulting from the Tcl deprecation. The Git GUI needs Tcl 8.5 but Tiger only ships 8.4. So the GUI app isn't built on Tiger, but then we have some new destroot logic that assumes the .app bundle is in fact there. I was working on a new +gui variant that always uses MacPorts tk but am away from my development machine this week.

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kencu @barracuda156 - I added the legacysupport portgroup in the commit here: 0c9bd9d

10.6 is still failing to build with the following:

Well, I guess clang fails, as usual. gcc compiles git without issues even on older systems.

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all those missing defines are actually available in the git source here, but at present only used on gcc… interesting… but perhaps we can make use of this

git/git@5ff01b1

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the guts may be 10.5+ only, however….

https://developer.apple.com/documentation/coreservices/1448000-fseventstreamstart

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has anyone tried a compiling on <10.10 system without FSMONITOR_DAEMON_BACKEND macros (it added in this commit)?

#14623

@herbygillot
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has anyone tried a compiling on <10.10 system without FSMONITOR_DAEMON_BACKEND macros (it added in this commit)?

#14623

Still seeing compilation failures for 10.6 (both x86_64 & i386):

x86_64

Undefined symbols for architecture x86_64:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
Undefined symbols for architecture x86_64:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
Undefined symbols for architecture x86_64:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
ld: symbol(s) not found for architecture x86_64
ld: symbol(s) not found for architecture x86_64
ld: symbol(s) not found for architecture x86_64
Undefined symbols for architecture x86_64:
  "_arc4random_buf", referenced from:
clang:       _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
error: linker command failed with exit code 1 (use -v to see invocation)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Undefined symbols for architecture x86_64:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ld: symbol(s) not found for architecture x86_64
make: *** [git-shell] Error 1
make: *** Waiting for unfinished jobs....
make: *** [git-daemon] Error 1
Undefined symbols for architecture x86_64:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
ld: symbol(s) not found for architecture x86_64
make: *** [git-http-backend] Error 1
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [git-http-fetch] Error 1
make: *** [git-sh-i18n--envsubst] Error 1
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [git-imap-send] Error 1
make: Leaving directory

https://build.macports.org/builders/ports-10.6_x86_64-builder/builds/100553/steps/install-port/logs/stdio

i386:

Undefined symbols for architecture i386:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
Undefined symbols for architecture i386:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
Undefined symbols for architecture i386:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
ld: symbol(s) not found for architecture i386
Undefined symbols for architecture i386:
  "_arc4random_buf", referenced from:
      _git_mkstemps_mode in libgit.a(wrapper.o)
      _csprng_bytes in libgit.a(wrapper.o)
ld: symbol(s) not found for architecture i386
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [git-daemon] Error 1
ld: symbol(s) not found for architecture i386
make: *** Waiting for unfinished jobs....
make: *** [git-sh-i18n--envsubst] Error 1
make: *** [git-http-backend] Error 1
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [git-imap-send] Error 1
make: Leaving directory

https://build.macports.org/builders/ports-10.6_i386-builder/builds/66269/steps/install-port/logs/stdio

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing compilation failures for 10.6 (both x86_64 & i386)

legacysupport.newest_darwin_requires_legacy should be increased to 10. @kencu and @barracuda156 need to check locally if the compilation succeeds.

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turning fsmonitor off was a blunt stroke… I‘ll see if I might fix it for myself at least, as it looks to be usable for 10.5 and up, although I haven’t tried yet.

yes, legacysupport is needed up to 10, not 9

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

95080c9

@herbygillot
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

95080c9

Thank you @kencu, looks like that did the trick.

@kencu
Copy link
Contributor

@kencu kencu commented on ce4020d Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turning fsmonitor off was a blunt stroke…

here I sound ungrateful… didn’t mean to… thanks for taking the time to sort out the toggle, your time is very much appreciated!

@herbygillot
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I suppose we should still look into whether fsmonitor should stay disabled

Please sign in to comment.