Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
py-pikepdf: fix hardcode reference to homebrew for arm
See: pikepdf/pikepdf#322
- Loading branch information
1 parent
54ee1bb
commit d5f5499
Showing
2 changed files
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- setup.py.orig 2022-03-21 20:35:06.000000000 -0500 | ||
+++ setup.py 2022-03-21 20:35:36.000000000 -0500 | ||
@@ -19,8 +19,8 @@ | ||
if 'bsd' in sys.platform: | ||
extra_includes.append('/usr/local/include') | ||
elif 'darwin' in sys.platform and machine() == 'arm64': | ||
- extra_includes.append('/opt/homebrew/include') | ||
- extra_library_dirs.append('/opt/homebrew/lib') | ||
+ extra_includes.append('%PREFIX%/include') | ||
+ extra_library_dirs.append('%PREFIX%/lib') | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
Schamschula
Author
Contributor
|
||
|
||
try: | ||
from setuptools_scm import get_version |
So now on Darwin arm64 you add /opt/local/include and /opt/local/lib. But surely those paths are needed to build this on non-arm64 systems too. Thus surely those paths are already added elsewhere and don't need to be added here again. Seems like you could just remove the
elif
and the two following lines.