Skip to content

Commit

Permalink
folly: set known_fail for 10.11 and prior
Browse files Browse the repository at this point in the history
  • Loading branch information
@mascguy
mascguy committed Aug 12, 2022
1 parent 8eea3b9 commit dd0783f
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions devel/folly/Portfile
View file
Expand Up @@ -39,6 +39,16 @@ github.tarball_from releases
distname ${name}-v${version}
extract.mkdir yes

platform darwin {
if {${os.major} < 16} {
known_fail yes
pre-fetch {
ui_error "${subport} requires macOS 10.12 or later"
return -code error "incompatible macOS version"
}
}
}

set port_libfmt libfmt9
cmake.module_path-append \
${prefix}/lib/${port_libfmt}/cmake
Expand Down

5 comments on commit dd0783f

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mascguy Why though? I have almost fixed it for old systems. Give me some time, we just need to sort a silly linking error with google-glog.
#15689

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: I have fixed it. Will update the PR now.

@mascguy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: I have fixed it. Will update the PR now.

This was a temporary fix, as it's been broken for 10.11 and earlier for a while. But if your changes takes care of that, then great!

@barracuda156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: I have fixed it. Will update the PR now.

This was a temporary fix, as it's been broken for 10.11 and earlier for a while. But if your changes takes care of that, then great!

I can confirm it builds for PPC, but for Intel systems we need to check on buildbots. I suggest merging my PRs (it won't hurt anyone at the very least) and see if <10.12 build or not.

P. S. It may be necessary that identical compiler is used for gflags, google-glog and folly. For GCC I have added conditions to that effect. For Clang, I do not know the logic – if we see similar undefined symbol errors on Intel systems, we may need to add a similar condition for Clang.

@mascguy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it builds for PPC, but for Intel systems we need to check on buildbots. I suggest merging my PRs (it won't hurt anyone at the very least) and see if <10.12 build or not.

Let me know when you're done with your changes, and I'll test locally with earlier macOS releases. That will help avoid multiple fix iterations.

Please sign in to comment.