Skip to content

Commit

Permalink
boost PG: Make boost 1.71 default on Darwin9 and older
Browse files Browse the repository at this point in the history
  • Loading branch information
cjones051073 committed Jun 23, 2021
1 parent 44b2947 commit e531659
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion _resources/port1.0/group/boost-1.0.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
namespace eval boost { }

options boost.version
default boost.version 1.76
default boost.version {[boost::default_version]}

options boost.depends_type
default boost.depends_type lib
Expand All @@ -26,6 +26,16 @@ default boost_cache_ldflags ""
default boost_cache_cmake_flags ""
default boost_cache_env_vars ""

proc boost::default_version {} {
global os.platform os.major
# Pin version on Darwin9 and older to pre-c++11 version (1.71)
if { ${os.platform} eq "darwin" && ${os.major} <= 9 } {
return 1.71
} else {
return 1.76
}
}

proc boost::version {} {
return [option boost.version]
}
Expand Down

6 comments on commit e531659

@evanmiller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this branch logic still needed? Boost176 builds fine on Tiger as of #11678

@cjones051073
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in a position to test anything on these older systems, so cannot really comment. But if 1.76 is fine there now probably not...

@evanmiller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.76 compiles fine on these systems with GCC7.

@kencu
Copy link
Contributor

@kencu kencu commented on e531659 Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Evan can only check Tiger PPC, we should confirm on intel before we say with certainty though, and confirm with leopard.

@kencu
Copy link
Contributor

@kencu kencu commented on e531659 Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boost176 build passes on 10.5 PPC and 10.4 Intel i386, but fails on 10.5 Intel i386. I'll open a ticket and someone can look into it.

@kencu
Copy link
Contributor

@kencu kencu commented on e531659 Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.