New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asciidoc: Fix checksums error due to stealth upgrade #10018
Conversation
Notifying maintainers: |
Hi John: One more detail to take care of...see https://trac.macports.org/wiki/PortfileRecipes#stealth-updates Edit: Actually, there is a new 9.1.0 release. Might as well update to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add dist_subdir, otherwise users may or may not end up with our mirrored copy and experience checksum mismatches.
I've just pushed an update that includes rev'ing to 9.1.0 and adds both a version and dist_subdir to the portfile. |
That last force push was to remove a redundant version number in the portfile |
textproc/asciidoc/Portfile
Outdated
name asciidoc | ||
|
||
dist_subdir ${name}/${version} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but when updating the version, the stealth upgrade procedures do no longer apply, so the dist_subdir
is unnecessary and should not be set.
Sorry for the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good - learning as I go, so I appreciate the patience. It should be fixed in the Portfile now
...well, it looks like someone else just took care of this in the repo 8d6bc18 |
Closed since @larryv committed their own version... Someone should close the trac ticket to reflect this as resolved... |
Done, thanks for your help anyway! |
Description
Type(s)
Tested on
macOS 11.2.1 20D74
Xcode 12.4 12D4e
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?Reference trac ticket 62273 (https://trac.macports.org/ticket/62273)