Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoc: Fix checksums error due to stealth upgrade #10018

Closed
wants to merge 1 commit into from
Closed

asciidoc: Fix checksums error due to stealth upgrade #10018

wants to merge 1 commit into from

Conversation

jhoyt4
Copy link
Contributor

@jhoyt4 jhoyt4 commented Feb 13, 2021

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.2.1 20D74
Xcode 12.4 12D4e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

Reference trac ticket 62273 (https://trac.macports.org/ticket/62273)

@macportsbot
Copy link

Notifying maintainers:
@neverpanic for port asciidoc.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Feb 13, 2021
@ctreleaven
Copy link
Member

ctreleaven commented Feb 13, 2021

Hi John:

One more detail to take care of...see https://trac.macports.org/wiki/PortfileRecipes#stealth-updates

Edit: Actually, there is a new 9.1.0 release. Might as well update to that.

https://github.com/asciidoc-py/asciidoc-py/releases

Copy link
Member

@neverpanic neverpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add dist_subdir, otherwise users may or may not end up with our mirrored copy and experience checksum mismatches.

@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Feb 13, 2021

I've just pushed an update that includes rev'ing to 9.1.0 and adds both a version and dist_subdir to the portfile.

@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Feb 13, 2021

That last force push was to remove a redundant version number in the portfile

name asciidoc

dist_subdir ${name}/${version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but when updating the version, the stealth upgrade procedures do no longer apply, so the dist_subdir is unnecessary and should not be set.

Sorry for the confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - learning as I go, so I appreciate the patience. It should be fixed in the Portfile now

@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Feb 13, 2021

...well, it looks like someone else just took care of this in the repo 8d6bc18

@jhoyt4 jhoyt4 closed this Feb 13, 2021
@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Feb 13, 2021

Closed since @larryv committed their own version...

Someone should close the trac ticket to reflect this as resolved...

@jhoyt4 jhoyt4 deleted the asciidoc branch February 13, 2021 17:30
@neverpanic
Copy link
Member

Done, thanks for your help anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
4 participants