Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py-igraph: update dependencies #10169

Merged
merged 1 commit into from Mar 8, 2021
Merged

py-igraph: update dependencies #10169

merged 1 commit into from Mar 8, 2021

Conversation

szhorvat
Copy link
Contributor

@szhorvat szhorvat commented Mar 7, 2021 •
edited

Description

  • update dependencies given the changes in python-igraph 0.9
  • build with external (instead of bundled) dependencies when appropriate
  • remove py27 subport as Python 2.7 is no longer supported
  • remove variants
  • See: https://trac.macports.org/ticket/62399
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.6 18G8022
Xcode 11.3.1 11C504

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?

@macportsbot
Copy link

Notifying maintainers:
@nerdling for port py-igraph.

mf2k
mf2k requested changes Mar 7, 2021
View reviewed changes
python/py-igraph/Portfile Outdated Show resolved Hide resolved
@mf2k
Copy link
Contributor

mf2k commented Mar 7, 2021

The Trac ticket reference should be added to the commit message. Add this to the end:

See: https://trac.macports.org/ticket/62399

@szhorvat
py-igraph: update dependencies
d873991 
 * update dependencies given the changes in python-igraph 0.9
 * build with external (instead of bundled) dependencies when appropriate
 * remove py27 subport as Python 2.7 is no longer supported
 * remove variants
 * See: https://trac.macports.org/ticket/62399
@szhorvat
Copy link
Contributor Author

szhorvat commented Mar 7, 2021

@mf2k Thanks for the comments! The cmake dependency change was accidental, sorry about that. Please take another look.

Regarding the bison/flex build dependencies, I added these for consistency, but these are technically not necessary as macOS does ship old (but compatible) versions of these.

@nerdling nerdling merged commit 6493ca3 into macports:master Mar 8, 2021
@szhorvat szhorvat deleted the py-igraph-0.9.0_1 branch September 25, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mf2k mf2k mf2k approved these changes

Assignees

@nerdling nerdling

Labels
maintainer: open Affects an openmaintainer port maintainer type: bugfix type: update
Milestone
No milestone
4 participants
@szhorvat @macportsbot @mf2k @nerdling