Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-tensorflow-probability: Submission #10295

Merged
merged 1 commit into from Mar 26, 2021

Conversation

essandess
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@essandess
Copy link
Contributor Author

@cjones051073 I've update this to the bazel PG, but am seeing this tcl { issue being thrown to bash in the post-build block for both bazel.post_build_cmd and clean:

INFO: Build completed successfully, 644 total actions
DEBUG: Executing proc-post-org.macports.build-build-0
DEBUG: system -W /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/probability-0.12.1: {./bazel-bin/pip_pkg /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work}
sh: {./bazel-bin/pip_pkg: No such file or directory
Command failed: {./bazel-bin/pip_pkg /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work}
Exit code: 127
Error: Failed to build py39-tensorflow-probability: command execution failed

@cjones051073
Copy link
Member

@cjones051073 I've update this to the bazel PG, but am seeing this tcl { issue being thrown to bash in the post-build block for both bazel.post_build_cmd and clean:

INFO: Build completed successfully, 644 total actions
DEBUG: Executing proc-post-org.macports.build-build-0
DEBUG: system -W /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/probability-0.12.1: {./bazel-bin/pip_pkg /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work}
sh: {./bazel-bin/pip_pkg: No such file or directory
Command failed: {./bazel-bin/pip_pkg /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work}
Exit code: 127
Error: Failed to build py39-tensorflow-probability: command execution failed

look at how I define the command in the tensor flow port. You need to remove the quotes.

@essandess
Copy link
Contributor Author

look at how I define the command in the tensor flow port. You need to remove the quotes.

Thanks! That works, but there's still the clean line. I haven't touched that…

Build complete. Wheel files are in /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work
DEBUG: system -W /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/probability-0.12.1: {CC_OPT_FLAGS=-march=x86-64 BAZEL_USE_CPP_ONLY_TOOLCHAIN=1  bazel --max_idle_secs=30 --output_user_root=/opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/bazel_build} clean
sh: {CC_OPT_FLAGS=-march=x86-64: command not found
Command failed: {CC_OPT_FLAGS=-march=x86-64 BAZEL_USE_CPP_ONLY_TOOLCHAIN=1  bazel --max_idle_secs=30 --output_user_root=/opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/bazel_build} clean
Exit code: 127
Error: Failed to build py39-tensorflow-probability: command execution failed

@cjones051073
Copy link
Member

look at how I define the command in the tensor flow port. You need to remove the quotes.

Thanks! That works, but there's still the clean line. I haven't touched that…

Build complete. Wheel files are in /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work
DEBUG: system -W /opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/probability-0.12.1: {CC_OPT_FLAGS=-march=x86-64 BAZEL_USE_CPP_ONLY_TOOLCHAIN=1  bazel --max_idle_secs=30 --output_user_root=/opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/bazel_build} clean
sh: {CC_OPT_FLAGS=-march=x86-64: command not found
Command failed: {CC_OPT_FLAGS=-march=x86-64 BAZEL_USE_CPP_ONLY_TOOLCHAIN=1  bazel --max_idle_secs=30 --output_user_root=/opt/local/var/macports/build/_opt_local_ports_python_py-tensorflow-probability/py39-tensorflow-probability/work/bazel_build} clean
Exit code: 127
Error: Failed to build py39-tensorflow-probability: command execution failed

your ports tree cannot be up to date, as I removed the use of the env vars in the clean line some time ago. Please update and try again.

@essandess
Copy link
Contributor Author

your ports tree cannot be up to date, as I removed the use of the env vars in the clean line some time ago. Please update and try again.

Indeed, thank you. For posterity, I wasn't aware of this portindex behavior when you add file://${prefix}/ports to ${prefix}/etc/macports/sources.conf and throw stuff into ${prefix}/ports/_resources/port1.0/group/. portindex uses the local port groups too! That can be handy. But also confusing if you're using an out-of-date copy:

sudo rm ${prefix}/ports/_resources/port1.0/group/bazel-1.0.tcl

@cjones051073 cjones051073 merged commit c759c61 into macports:master Mar 26, 2021
@essandess essandess deleted the py-tensorflow-probability branch March 26, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants