Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qBittorrent: use macports-libcxx #10382

Closed
wants to merge 1 commit into from
Closed

qBittorrent: use macports-libcxx #10382

wants to merge 1 commit into from

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Mar 23, 2021

closes: https://trac.macports.org/ticket/62441

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.10.5 14F2511
Xcode 7.2.1 7C1002

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@i0ntempest for port qBittorrent.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement labels Mar 23, 2021
@i0ntempest
Copy link
Member

i0ntempest commented Mar 24, 2021

Thank you for all this. You may merge once you sort everything out.
Also maybe revbump since you fixed development target?

@kencu
Copy link
Contributor Author

kencu commented Mar 25, 2021

qbittorrent raised their qt5 requirements to 5.12...so this fix won't change that fact. We may see this pattern play out fairly often, limiting the usefulness of the upgraded libcxx.

Have to consider now how fast that will obsolete qt5 < 5.12, and whether it's worth doing this at all at this point.

@kencu kencu closed this Mar 28, 2021
@kencu kencu deleted the qbittorrentnewlibcxx branch April 1, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement
3 participants