Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobject-introspection PG: respect all CFLAGS #10434

Merged
merged 1 commit into from Mar 31, 2021

Conversation

MarcusCalhoun-Lopez
Copy link
Contributor

Fixes https://trac.macports.org/ticket/62410

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.6 17G14042
Xcode 10.1 10B61

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@danchr for port libvirt-glib.
@dbevans for port telepathy-glib, telepathy-logger, libgda5, glade, upower, amtk, anjuta, evince, gcr, gdl3, gfbgraph, gjs, gnome-autoar, gnome-characters, gnome-maps, gnome-menus, gnome-music, gnome-online-accounts, gnome-panel, gnome-weather, gnumeric, goffice, goocanvas2, gspell, gtksourceview3, libgnome-keyring, libgnomekbd, libgtop, libsocialweb, libunique, libunique3, liferea, nautilus, polari, rest, tracker, uhttpmock, vte, clutter-gst, clutter-gst3, clutter-gtk, clutter, cogl, gegl-0.3, libmediaart, librsvg, osm-gps-map, poppler, gmime3, gssdp, gupnp-av, gupnp-dlna, gupnp-igd, gupnp, libgrss, libnice, rygel, policykit, gtkspell3.
@ryandesign for port keybinder-3.0, keybinder, pango-devel, pango.
@jcupitt for port vips.
@bgilbert for port vips.
@i0ntempest for port avahi.

@cjones051073
Copy link
Member

Hmm, its a little difficult to review this given the significant changes to the PG and the fact the builds fail presumably due to the number of touched ports. Are we happy to merge as is and assume the PG changes work ?

Copy link
Member

@cjones051073 cjones051073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please mention in the commit message that you also bump dependent ports.

Change will affect builds, so increase revision of dependent ports.
Fixes https://trac.macports.org/ticket/62410
@MarcusCalhoun-Lopez
Copy link
Contributor Author

I have updated the commit message.
Some of these ports do not build on any platform.
However, the ones that do build seem to build properly on a macOS 10.13 VM.

@cjones051073 cjones051073 merged commit 50b5d8a into macports:master Mar 31, 2021
@MarcusCalhoun-Lopez MarcusCalhoun-Lopez deleted the gobject_fix branch March 31, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants