Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p5-*: add p5.32, remove p5.26 subports #10821

Merged
merged 3 commits into from Jun 20, 2021
Merged

p5-*: add p5.32, remove p5.26 subports #10821

merged 3 commits into from Jun 20, 2021

Conversation

mojca
Copy link
Member

@mojca mojca commented Apr 27, 2021

Description

This update sometimes causes various issues related to our CI, so we want to monitor our services once we push the merge button.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

/

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@fracai for port p5-www-curl.
@ctreleaven for port mythweb.28.
@dliessi for port p5-file-keepass, p5-net-smtp-tls-butmaintained, p5-pod-latex, p5-tex-encode, p5-utf8-all.
@TheKevJames for port p5-lwp-useragent-cached.
@nerdling for port p5-autodia, p5-crypt-gcrypt.
@ryandesign for port p5-class-csv, p5-filesys-notify-kqueue, p5-graphviz, p5-graphviz2, p5-html-extract, p5-html-lint, p5-html-tagfilter, p5-html-tokeparser-simple, p5-module-depends, p5-net-dns-resolver-programmable, p5-pango, p5-perlmagick.
@cardi for port p5-compress-raw-lzma, p5-io-compress-lzma, p5-test-cpan-meta-json.
@jpoliv for port p5-dancer-plugin-database, p5-dancer, p5-http-server-simple-psgi, p5-io-interface, p5-log-dispatch, p5-log-log4perl, p5-net-stomp, p5-netpacket, p5-pmtools, p5-set-scalar.
@chrstphrchvz for port p5-devel-refcount, p5-perl-languageserver, p5-tcl-ptk, p5-tcl-tk, p5-tcl, p5-tk-dynatabframe, p5-tk-idelayout, p5-tk-tablematrix, p5-tk, p5-tkx, p5-webservice-musicbrainz.
@danielluke for port p5-algorithm-annotate, p5-algorithm-diff, p5-bsd-resource, p5-class-autouse, p5-clone, p5-data-hierarchy, p5-file-type, p5-font-afm, p5-html-formatter, p5-html-tree, p5-internals, p5-ipc-run3, p5-locale-maketext-simple, p5-pathtools, p5-regexp-shellish, p5-spiffy, p5-svn-dump, p5-svn-notify, p5-test-base, p5-text-diff, p5-yaml.
@dbevans for port p5-algorithm-combinatorics, p5-algorithm-curvefit, p5-alien-base-modulebuild, p5-alien-build, p5-alien-editline, p5-alien-ffi, p5-alien-gimp, p5-alien-gmp, p5-alien-libuuid, p5-alien-libxml2, p5-any-uri-escape, p5-archive-tar-wrapper, p5-array-iterator, p5-astro-app-satpass2, p5-astro-coord-eci-tle-iridium, p5-astro-coord-eci-vsop87d, p5-astro-simbad-client, p5-astro-spacetrack, p5-authen-pam, p5-b-c, p5-b-cow, p5-b-debug, p5-b-flags, p5-backuppc-xs, p5-beam-emitter, p5-bio-cluster, p5-bio-db-embl, p5-bio-db-ncbihelper, p5-bio-variation, p5-boolean, p5-bytes-random-secure-tiny, p5-cache-lru, p5-cairo-gobject, p5-carp-clan-share, p5-chart-clicker, p5-check-isa, p5-class-accessor-lite, p5-clone-choose, p5-clone-pp, p5-code-tidyall, p5-color-library, p5-color-scheme, p5-commandable, p5-compress-lzf, p5-compress-stream-zstd, p5-config-identity, p5-config-jfdi, p5-config-mvp-reader-ini, p5-config-mvp-slicer, p5-config-mvp, p5-cpan-distnameinfo, p5-cpan-uploader, p5-crypt-curve25519, p5-crypt-openssl-guess, p5-crypt-smime, p5-dancer2-plugin-database, p5-dancer2-session-cookie, p5-data-dumper-names, p5-data-messagepack, p5-data-printer, p5-data-section-simple, p5-data-serializer, p5-data-structure-util, p5-datetime-calendar-christian, p5-datetime-calendar-julian, p5-datetime-format-flexible, p5-datetime-format-natural, p5-datetime-set, p5-devel-leak, p5-devel-mat-dumper, p5-digest-whirlpool, p5-dist-zilla-app-command-regenerate, p5-dist-zilla-config-slicer, p5-dist-zilla-plugin-authority, p5-dist-zilla-plugin-autometaresources, p5-dist-zilla-plugin-bumpversionafterrelease, p5-dist-zilla-plugin-checkextratests, p5-dist-zilla-plugin-checkissues, p5-dist-zilla-plugin-checkmetaresources, p5-dist-zilla-plugin-checkprereqsindexed, p5-dist-zilla-plugin-checkselfdependency, p5-dist-zilla-plugin-checkstrictversion, p5-dist-zilla-plugin-contributorsfromgit, p5-dist-zilla-plugin-copyfilesfromrelease, p5-dist-zilla-plugin-dynamicprereqs, p5-dist-zilla-plugin-ensurelatestperl, p5-dist-zilla-plugin-ffi, p5-dist-zilla-plugin-generatefile-fromsharedir, p5-dist-zilla-plugin-git-contributors, p5-dist-zilla-plugin-git-describe, p5-dist-zilla-plugin-git-pushinitial, p5-dist-zilla-plugin-git-remote-check, p5-dist-zilla-plugin-github, p5-dist-zilla-plugin-githubmeta, p5-dist-zilla-plugin-installguide, p5-dist-zilla-plugin-keywords, p5-dist-zilla-plugin-makemaker-awesome, p5-dist-zilla-plugin-makemaker-fallback, p5-dist-zilla-plugin-metaprovides-package, p5-dist-zilla-plugin-metaprovides, p5-dist-zilla-plugin-minimumperl, p5-dist-zilla-plugin-modulebuildtiny-fallback, p5-dist-zilla-plugin-modulebuildtiny, p5-dist-zilla-plugin-mojibaketests, p5-dist-zilla-plugin-ourpkgversion, p5-dist-zilla-plugin-pod2readme, p5-dist-zilla-plugin-podweaver, p5-dist-zilla-plugin-prereqs-authordeps, p5-dist-zilla-plugin-promptifstale, p5-dist-zilla-plugin-readmeanyfrompod, p5-dist-zilla-plugin-rewriteversion-transitional, p5-dist-zilla-plugin-run, p5-dist-zilla-plugin-test-compile, p5-dist-zilla-plugin-test-minimumversion, p5-dist-zilla-plugin-test-reportprereqs, p5-dist-zilla-plugin-versionfrommainmodule, p5-dist-zilla-pluginbundle-git-checkfor, p5-dist-zilla-pluginbundle-git-versionmanager, p5-dist-zilla-pluginbundle-starter, p5-dist-zilla-role-dynamicconfig, p5-dist-zilla-role-filewatcher, p5-dist-zilla-role-modulemetadata, p5-dist-zilla-role-pluginbundle-pluginremover, p5-dist-zilla-role-registerstash, p5-dist-zilla-role-repofileinjector, p5-dist-zilla-role-stash-plugins, p5-dist-zilla-stash-podweaver, p5-dist-zilla, p5-dumbbench, p5-email-address-xs, p5-extutils-cchecker, p5-ffi-c, p5-ffi-platypus-lang-rust, p5-ffi-platypus-type-enum, p5-ffi-platypus, p5-file-chmod, p5-file-copy-link, p5-file-copy-recursive-reduced, p5-file-nfslock, p5-file-share, p5-file-sharedir-dist, p5-file-sync, p5-find-lib, p5-font-freetype, p5-forest, p5-future-io, p5-geo-coder-osm, p5-geo-webservice-elevation-usgs, p5-geometry-primitive, p5-getopt-usaginator, p5-gimp, p5-git-raw, p5-git-wrapper, p5-glib-object-introspection, p5-goto-file, p5-graphics-color, p5-graphics-primitive-driver-cairo, p5-graphics-primitive, p5-graphviz2-dbi, p5-gstreamer1, p5-gtk2-sourceview2, p5-gtk3, p5-hash-objectify, p5-hash-util-fieldhash-compat, p5-html-entities-interpolate, p5-html-formattext-withlinks, p5-html-restrict, p5-http-cookiemonster, p5-http-entity-parser, p5-http-multipartparser, p5-http-tiny-mech, p5-http-tiny-multipart, p5-http-xscookies, p5-http-xsheaders, p5-image-exiftool, p5-importer, p5-io-compress-lzf, p5-io-compress-zstd, p5-io-fdpass, p5-iri, p5-layout-manager, p5-lib-relative, p5-lingua-en-pluraltosingular, p5-list-compare, p5-list-moreutils-xs, p5-list-someutils-xs, p5-list-someutils, p5-log-any-adapter-callback, p5-log-any-adapter-tap, p5-log-dispatch-filerotate, p5-log-dispatchouli, p5-log-handler, p5-long-jump, p5-lwp-consolelogger, p5-lwp-curl, p5-lwpx-paranoidagent, p5-mac-osversion, p5-mail-authenticationresults, p5-math-anynum, p5-math-bigint-fastcalc, p5-math-gcomplex, p5-math-int64, p5-math-longdouble, p5-math-matrixreal, p5-math-mpc, p5-math-symbolic, p5-math-utils, p5-mce-shared, p5-mce, p5-metacpan-client, p5-metrics-any, p5-mo, p5-mock-config, p5-modern-perl, p5-module-build-ffi, p5-module-util, p5-moosex-clone, p5-moosex-daemonize, p5-moosex-insideout, p5-moosex-slurpyconstructor, p5-moosex-types-uri, p5-mousex-foreign, p5-net-dns-resolver-mock, p5-net-dns-sec, p5-net-dns, p5-net-github, p5-net-libidn2, p5-net-smtp-tls, p5-net-smtps, p5-number-witherror, p5-object-hashbase, p5-opcodes, p5-package-pkg, p5-parallel-forkmanager, p5-parallel-iterator, p5-params-validationcompiler, p5-parse-cpan-packages-fast, p5-parse-edid, p5-parse-mime, p5-pdf-api2-xs, p5-pdl-transform-color, p5-perl-prereqscanner, p5-pithub, p5-plack-test-agent, p5-pod-elemental-makeselector, p5-pod-elemental-perlmunger, p5-pod-elemental-transformer-list, p5-pod-elemental-transformer-verbatim, p5-pod-elemental, p5-pod-simple-latex, p5-pod-weaver-plugin-ensureuniquesections, p5-pod-weaver-section-allowoverride, p5-pod-weaver-section-contributors, p5-pod-weaver-section-generatesection, p5-pod-weaver, p5-poppler, p5-ppix-quotelike, p5-proc-guard, p5-proc-processtable, p5-rdf-query, p5-rdf-trine, p5-ref-util-xs, p5-ref-util, p5-role-hasmessage, p5-role-identifiable, p5-semver, p5-set-array, p5-set-infinite, p5-software-license, p5-specio-library-path-tiny, p5-specio, p5-sql-abstract-classic, p5-starman, p5-statistics-caseresampling, p5-statistics-chisquare, p5-statistics-covid, p5-string-ttylength, p5-string-util, p5-sub-delete, p5-sub-handlesvia, p5-svg, p5-syntax-keyword-try, p5-term-ansicolor, p5-test-simple, p5-test2-harness, p5-test2-plugin-cover, p5-test2-plugin-dbiprofile, p5-test2-plugin-ioevents, p5-test2-plugin-memusage, p5-test2-plugin-nowarnings, p5-test2-plugin-uuid, p5-test2-suite, p5-test2-tools-explain, p5-text-flow, p5-text-template-simple, p5-text-visualwidth, p5-tie-function, p5-tie-refhash-weak, p5-time-local, p5-tk-graphviz, p5-tk-matchentry, p5-treepath-role-graph, p5-treepath, p5-unicode-checkutf8, p5-unicode-eastasianwidth, p5-unicode-normalize, p5-unix-groups-ffi, p5-uri-escape-xs, p5-uri-fromhash, p5-uri-query, p5-uuid-ffi, p5-version-next, p5-www-form-urlencoded-xs, p5-www-form-urlencoded, p5-www-mechanize-cached, p5-xs-parse-sublike, p5-xsloader, p5-xstring, p5-xxx, p5-yaml-libyaml-api, p5-yaml-pp-libyaml, p5-yaml-pp, p5-zmq-ffi.
@Schamschula for port p5-authen-radius, p5-data-hexdump, p5-module-manifest, p5-x11-protocol-other.
@lockhart for port p5-sgmlspm.
@ptman for port p5-text-markdown.
@jtrammel for port p5-term-editline.
@kurthindenburg for port p5-cache-cache, p5-class-tiny, p5-error, p5-file-sharedir-projectdistdir, p5-ipc-sharelite, p5-json-parse, p5-musicbrainz-discid, p5-path-finddev, p5-path-isdev, p5-perl-critic, p5-posix-strftime-compiler, p5-ppix-regexp, p5-test-mocktime, p5-xml-namespacesupport, p5-xml-sax-base, p5-xml-sax-expat, p5-xml-sax.
@Ionic for port p5-cryptx.
@nottwo for port p5-json-xs.
@outis for port p5-net-bonjour.
@mvgrimes for port p5-pdl.
@eborisch for port p5-app-svn-bisect.
@mklein-de for port p5-getopt-simple.
@danchr for port p5-io-lambda, p5-net-eboks.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer labels Apr 27, 2021
@ctreleaven
Copy link
Member

The build failure on mythweb.28 is expected. Depends on non-default variants.

At some point, I will go over the myth* ports and update to a supported perl version (or declare some of the ports obsolete) among other maintenance.

Schamschula added a commit that referenced this pull request Apr 30, 2021
add p5.32, remove p5.26 subport
See: #10821
Schamschula added a commit that referenced this pull request Apr 30, 2021
add p5.32, remove p5.26 subport
See: #10821
Schamschula added a commit that referenced this pull request Apr 30, 2021
Add p5.32, remove p5.26 branches
See: #10821
Schamschula added a commit that referenced this pull request May 1, 2021
@reneeotten
Copy link
Contributor

@mojca what do you want to do with this PR? Fix the conflicts and merge, or...? It seems that leaving this open for too long isn't very helpful as it will inevitably result in merge conflicts as soon as one of the packages is updated.

@mojca
Copy link
Member Author

mojca commented Jun 20, 2021

I plan to (fix and) merge this. The problem is that there are some open / pending issues with efficiency on the buildbot side, usually resulting in the buildbot stuck building these ports for up to one week (truth to be told I'm not following exactly). From what I remember merging this has always caused one issue or another.

But if there's no activity towards optimisations foreseen in the near future, maybe I'll just merge ...

@ryandesign

@mojca mojca merged commit 9ef2ebf into macports:master Jun 20, 2021
@mojca mojca deleted the p5.32 branch June 20, 2021 14:45
@jmroot
Copy link
Member

jmroot commented Jun 21, 2021

A lot of the portfiles seem to have 5.325.32 (sic) in perl5.branches now.

@mojca
Copy link
Member Author

mojca commented Jun 21, 2021

Arghhhhh. Thanks for pointing this out.
I've been using the same regex for years and it worked well ... until someone decided to only add subports to a handful of ports. I did go through the first round a bit more carefully, but I didn't pay so much attention this time.

I'm fixing it now.

mojca added a commit that referenced this pull request Jun 21, 2021
Revert the result of a buggy regex applied in 96a5edb.
See: #10821
@ryandesign
Copy link
Contributor

Thanks. Since the problem affected p5.32-module-build, a lot of p5.32 ports failed to build. We should force build all affected p5.32 ports on those builders that have already processed the initial commits from this PR (10.7, 10.8, 10.14, 10.15, 11 x86_64, 11 arm64). Ideally we should list the p5.32 subports and not the p5 main ports to avoid unnecessary extra processing by the buildbot.

@mojca
Copy link
Member Author

mojca commented Jun 22, 2021

I started new forced builds on 10.7, 10.8 and 11 arm64. These are the ones that have completely finished building the ports from that commit. I'll wait for the other workers to finish the job and then extract the summary and reschedule just the failed subports for 5.32. I guess I should add subports for 5.34 as well and then we could try to migrate directly to 5.34.

https://trac.macports.org/ticket/63126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment