-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crossgcc-1.0: Updated compiler blacklist gcc11 #11039
Conversation
Notifying maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can build the ports on the buildbot manually once this gets merged. I see no reason for increasing the revision.
But if you do want to build them automatically, we can rename the patches instead to get rid of the lint warnings ;)
PS: I approved the review, but that still means that it makes sense to address the minor issues mentioned above before merging the code. I'm not sure how to un-approve before those minor items are handled, but I hope it doesn't really matter. Thank you very much for handling this. |
837a515
to
c51f261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the revision bumps, removed the comment from crossgcc
, rather not touch gcc11
& gcc-devel
but maybe @kencu can add the note for keeping crossgcc
in sync.
I missed this comment before, but that’s a good idea. But I won’t be near my system until I’m done with work. Would that need to be in another PR or just modify this one? |
Conditionally append compiler blacklist for gcc11+ only Added the missing compiler_blacklist_versions PortGroup without this the compiler just default to /usr/bin/clang (tested on OS X 10.9) Closes https://trac.macports.org/ticket/62901
c51f261
to
a9cad56
Compare
Restored the “Taken from gcc11” comment. |
Very sorry, I don't know much about crossgcc. |
But you do know about gcc, the idea is to add a note within gcc11/gcc-devel (for it become gcc12 etc) to also keep crossgcc Portgroup in sync for compiler requirements. For this PR I’d taken the information directly from gcc11. |
Conditionally append compiler blacklist for gcc11+ only
Added the missing compiler_blacklist_versions PortGroup without this the compiler just default to /usr/bin/clang (tested on OS X 10.9)
revision bumped i686-w64-mingw32-gcc & x86_64-w64-mingw32-gcc
Closes https://trac.macports.org/ticket/62901
Description
This was tested on an OS X 10.9 VM, prior versions of mingw-bootstrap etc were removed prior to testing to ensure this worked correctly.
Type(s)
Tested on
macOS 10.9.5 13F1911 x86_64
Xcode Command Line Tools installed via
xcode-select —install
Verification
port lint
?sudo port test
?sudo port -vst install
?