Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim: switch back to LuaJIT #11168

Merged
merged 3 commits into from Jun 1, 2021
Merged

neovim: switch back to LuaJIT #11168

merged 3 commits into from Jun 1, 2021

Conversation

l2dy
Copy link
Member

@l2dy l2dy commented May 28, 2021

Description

Upstream officially supports Lua 5.1 or LuaJIT only, and Neovim 0.5 will only build with either of them, see neovim/neovim#12415.

Note: luv and luv-luajit confict with each other, so upgrading requires manual intervention (deactivation).

P.S. Last switch to Lua 5.3 was made because we did not have ports for the lua51-* dependencies. It builds, but was not thoroughly tested in regard to Lua functionalities.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.7 19H1030 x86_64
Xcode 12.3 12C33

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@raimue for port neovim.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix labels May 28, 2021
editors/neovim/Portfile Outdated Show resolved Hide resolved
port:lua-mpack \
port:lua-luabitop \
port:luv
port:msgpack \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also taking the chance to upgrade msgpack. Few ports in the tree are using msgpack1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also taking the chance to upgrade msgpack. Few ports in the tree are using msgpack1.

Since msgpack and msgpack1 conflict, it would have been nice to use the "deactivate hack" or something to prevent upgrade from failing over the conflict

@l2dy
Copy link
Member Author

l2dy commented Jun 1, 2021

Maintainer timeout. Merging.

@l2dy l2dy merged commit 31d7941 into macports:master Jun 1, 2021
@l2dy l2dy deleted the fix/neovim branch June 1, 2021 15:57
@judaew
Copy link
Member

judaew commented Jun 1, 2021

Hi @l2dy. Thanks for the contribution 🌟.

Lua is used at runtime. I'm afraid this update broke something... And now Neovim crashes. Could you take a look at my ticket?
https://trac.macports.org/ticket/63011

@l2dy
Copy link
Member Author

l2dy commented Jun 2, 2021

@judaew Thanks for the report. Try to update luajit or install luajit-openresty instead of it.

Let's move further discussion to the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix type: enhancement
6 participants