Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBLAS: update release to 0.3.16 and devel to OpenBLAS 20210712-ea8e2080 #11576

Merged
merged 1 commit into from Jul 13, 2021

Conversation

michaelld
Copy link
Contributor

Description

OpenBLAS: update release to 0.3.16 and devel to OpenBLAS 20210712-ea8e2080
Remove integrated patch

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.5 20G5065a
Xcode 12.3 12C33
using +gccdevel

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@NicosPavlov for port OpenBLAS.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer maintainer: open Affects an openmaintainer port type: enhancement type: update labels Jul 12, 2021
@NicosPavlov
Copy link
Contributor

Hi, thanks for the PR, it looks all good to me.

It is just a suggestion and could be done on a separate PR, but I wonder if the update could be an occasion for fixing the architecture for arm, as we are still left with something unset:
if {${os.arch} eq "arm"} {
# FIXME use correct arch name
#set blas_arch "???"
}

Everything I read indicate that it should be:
set blas_arch "ARMV8"
but I do not have an M1 machine to personally confirm and test. At worst, ARMV8 should still work as it is the generic ARM but possibly with slightly degraded performance. In any case, OpenBLAS does not have a specific optimization for M1.

@michaelld
Copy link
Contributor Author

I'm going to go ahead and merge this in, per maintainer approvals (me too). Let's do the ARM changes in a different PR. I just received my brand spankin' new Mac Mini M1 (which replaces my DTK, some 3 months without an ARM Mac ...) and will be slowly (as my "spare" time allows) plowing through many ports such as OpenBLAS to see what sort of fixes are required to be compatible with ARM64 / M1.

@michaelld michaelld merged commit 08af366 into macports:master Jul 13, 2021
@michaelld michaelld deleted the OpenBLAS_update_to_0.3.16 branch July 13, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: enhancement type: update
3 participants