Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffutils: update maintainer #11927

Closed
wants to merge 2 commits into from
Closed

diffutils: update maintainer #11927

wants to merge 2 commits into from

Conversation

schaiba
Copy link

@schaiba schaiba commented Aug 19, 2021

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@ra1nb0w
Copy link
Contributor

ra1nb0w commented Aug 19, 2021

I don't see any previous contribution from you therefore you should not be the maintainer.
Said that, you need to add openmaintainer and use the tag diffutils: in the commit.
Read https://guide.macports.org/#project.contributing

@ra1nb0w ra1nb0w changed the title Update maintainer diffutils: update maintainer Aug 19, 2021
@ra1nb0w
Copy link
Contributor

ra1nb0w commented Aug 19, 2021

Why do you want to be the maintainer since you haven't pushed any commit in the past?

@schaiba
Copy link
Author

schaiba commented Aug 19, 2021

Why do you want to be the maintainer since you haven't pushed any commit in the past?

I maintain diffutils in FreeBSD as well, so I thought I might be able to help here as well.

@ra1nb0w
Copy link
Contributor

ra1nb0w commented Aug 19, 2021

Please, merge the two commits in one using the prefix diffutils: in the header. See the other commits in macports-ports and the url that I post.
Personally, before changing the maintainer I would like to see a few contributions. But listen what others developers have to say.

@schaiba schaiba closed this Aug 19, 2021
@schaiba schaiba deleted the Maintainership-request-for-diffutils branch August 19, 2021 13:35
@kencu
Copy link
Contributor

kencu commented Aug 19, 2021

that didn't work out too well.

@reneeotten
Copy link
Contributor

reneeotten commented Aug 19, 2021

@ra1nb0w this doesn't seem to be the best way to welcome newcomers with an interest to contribute...

@schaiba opened a Trac ticket about this and I suggested him to submit a PR instead as that is the way we would like people to contribute their updates/changes. I agree that changing just the maintainer line without having contributed before to MacPorts might seem a little awkward, but I would just view it as showing interest to go and maintain this port and would be perfectly fine with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants