Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql8: use MacPorts' libc++ on macOS ≤10.12 #12644

Closed
wants to merge 1 commit into from

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Oct 21, 2021

…for std::shared_timed_mutex and std::bad_optional_access
See: https://trac.macports.org/ticket/60853

Description

Tested on

Untested.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@herbygillot for port mysql8.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Oct 21, 2021
@chrstphrchvz
Copy link
Contributor Author

Pinging @cjones051073 in case of interest.

@chrstphrchvz chrstphrchvz marked this pull request as draft October 21, 2021 16:32
@chrstphrchvz
Copy link
Contributor Author

Now that I see 1cdb3d2, would migrating this port to libc++ work to provide std::bad_optional_access for macOS 10.12 and earlier (if there is interest in this port working on older macOS)?

@herbygillot
Copy link
Member

Now that I see 1cdb3d2, would migrating this port to libc++ work to provide std::bad_optional_access for macOS 10.12 and earlier (if there is interest in this port working on older macOS)?

I think there is always interest in making software work with older versions of macOS, if you can figure out how.

…for std::shared_timed_mutex and std::bad_optional_access
See: https://trac.macports.org/ticket/60853
@chrstphrchvz chrstphrchvz changed the title mysql8: use MacPorts' libc++ on macOS ≤10.11 mysql8: use MacPorts' libc++ on macOS ≤10.12 Oct 21, 2021
@chrstphrchvz
Copy link
Contributor Author

If this PR or similar approach to support macOS ≤10.12 is rejected, then https://trac.macports.org/ticket/60379 can also be closed.

@chrstphrchvz chrstphrchvz marked this pull request as ready for review October 21, 2021 17:00
@cjones051073
Copy link
Member

In order for this approach to work at all, you need to remove the known_fail block.

@cjones051073
Copy link
Member

tried this but it does not help]

:info:build /opt/local/var/macports/build/_Users_chris_Projects_MacPorts_ports_databases_mysql8/mysql8/work/mysql-8.0.27/storage/temptable/include/temptable/kv_store.h:76:50: error: 'shared_timed_mutex' is unavailable: introduced in macOS 10.12
:info:build       std::conditional_t<std::is_same<Lock, std::shared_timed_mutex>::value,

I think it is going to be excessively hard to support < macOS 10.13.

@chrstphrchvz chrstphrchvz deleted the mysql8027 branch October 21, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
4 participants