Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: Update to version 9.2.1 and add native arm64 support #12730

Closed
wants to merge 1 commit into from

Conversation

essandess
Copy link
Contributor

Description

The prebuilt binaries work.

Bootstrapping doesn't currently work because of this issue: https://gitlab.haskell.org/ghc/ghc/-/issues/19631

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.6.1 20G224 x86_64
Xcode 13.1 13A1030d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@pmetzger
Copy link
Member

You put "WIP" into the title here. Does that mean you don't want this committed?

@essandess
Copy link
Contributor Author

You put "WIP" into the title here. Does that mean you don't want this committed?

My preference is that we wait until upstream fixes the bootstrapping issue, of which they're aware. But if there is demand now for a prebuilt binary, especially for native M1 builds, we have this in our pocket.

@pmetzger pmetzger added the wip Work in progress label Oct 31, 2021
@pmetzger
Copy link
Member

I don't love "WIP" merge requests because they make it harder for people doing maintenance on the merge queue to see what they do and don't have to work on. However for now I've just added the "wip" tag.

@mascguy mascguy self-assigned this Nov 6, 2021
@cjones051073 cjones051073 marked this pull request as draft November 10, 2021 22:25
@cjones051073 cjones051073 changed the title ghc: Update to version 9.2.1 and add native arm64 support [WIP] ghc: Update to version 9.2.1 and add native arm64 support Nov 10, 2021
@cjones051073 cjones051073 removed wip Work in progress DO_NOT_MERGE_YET labels Nov 10, 2021
@cjones051073
Copy link
Member

If you wish to indicate a PR is not ready, please use the github draft feature, which actually prevents it from being merged, rather than just adding random labels which don’t prevent merging, thanks.

@cjones051073
Copy link
Member

I don't love "WIP" merge requests because they make it harder for people doing maintenance on the merge queue to see what they do and don't have to work on. However for now I've just added the "wip" tag.

Once a PR has been made draft, you can just exclude it from the list of PRs you need to scan through by just appending draft:false to the filters… i.e.

https://github.com/macports/macports-ports/pulls?q=is%3Apr+is%3Aopen+draft%3Afalse

@pmetzger
Copy link
Member

@essandess any progress on this? It would be nice to have things like pandoc working right on M1.

@essandess
Copy link
Contributor Author

@pmetzger This is an upstream issue and has nothing to do with us.

Also, ghc and pandoc and other stack-based x86_64 builds already work on M1. They’re just not native binaries.

@pmetzger
Copy link
Member

This is an upstream issue and has nothing to do with us.

I know, but have they done anything? It's been a while.

@essandess
Copy link
Contributor Author

This is an upstream issue and has nothing to do with us.
I know, but have they done anything? It's been a while.

The issue link is in the commit above. Clicking on it., I see that it’s open and that they’re working the issue.

@reneeotten
Copy link
Contributor

what's the plan here. If we're waiting for upstream to fix something before we can merge this PR let's just close it for now and you can submit something again once that has happened.

@essandess
Copy link
Contributor Author

what's the plan here. If we're waiting for upstream to fix something before we can merge this PR let's just close it for now and you can submit something again once that has happened.

Yep, waiting for upstream. I’ll close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants