Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darktable: update to 3.6.1 #12836

Merged
merged 1 commit into from Nov 10, 2021
Merged

darktable: update to 3.6.1 #12836

merged 1 commit into from Nov 10, 2021

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Nov 6, 2021 •
edited

Description

Update DarkTable to 3.6.1

Closes: https://trac.macports.org/ticket/63634

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.6 17G14019
Xcode 10.1 10B61

macOS 10.14.6 18G103
Xcode 11.3.1 11C505

macOS 10.15.6 19G2021
Xcode 12.0 12A7209

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port darktable.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update labels Nov 6, 2021
@mascguy
Copy link
Member Author

mascguy commented Nov 6, 2021 •
edited

Marcus, thus far I've tested both the X11 version, as well as Quartz. Still need to test the OpenMP variant, though.

EDIT: It looks like OpenEXR is being properly found; misread the output from the configure stage. So looking good!

@mascguy
Copy link
Member Author

mascguy commented Nov 6, 2021 •
edited

It looks like the OpenMP variant fails to build against MacPorts Clang 9:

CMake Error at src/external/rawspeed/cmake/compiler-versions.cmake:48 (message):
  LLVM Clang C compiler version 9.0.1 is not supported in with-OpenMP build
  mode.

EDIT: Added a CMake patch to eliminate the OpenMP-related compiler restrictions, for Clang. Combined with the compiler blacklist, I think (?) we might be okay. But we should take a 2nd look regardless.

@mascguy mascguy force-pushed the mascguy-darktable branch 2 times, most recently from 505e6f7 to 1b5a9ca Compare November 6, 2021 22:19
@mascguy
Copy link
Member Author

mascguy commented Nov 6, 2021 •
edited

Update: DarkTable 3.6.x may be another possible candidate for use of Ken's macports-libcxx, as the build fails on 10.12 due to use of 10.13+ libcxx features. The details in the following ticket, for gromacs, illustrate the issue:

63818 - gromacs/gromacs-plumed: build requires macOS 10.13+; possible candidate for macports-libcxx

CC: @kencu

@mascguy mascguy force-pushed the mascguy-darktable branch 2 times, most recently from e3ab839 to 5901fb3 Compare November 7, 2021 13:15
@mascguy
Copy link
Member Author

mascguy commented Nov 7, 2021 •
edited

To proactively test/validate this update, added a corresponding Devel port.

@mascguy mascguy force-pushed the mascguy-darktable branch 3 times, most recently from 5f32398 to 128e472 Compare November 10, 2021 22:25
@mascguy
darktable: update to 3.6.1
22ce989 
- Variant openmp: ease compiler restrictions; update required openmp version to 4.5
- Enable use of 'macports-libcxx', via pg 'legacysupport', for macOS 10.12 and earlier
- Set macOS app name
- See: https://trac.macports.org/ticket/63634
@mascguy mascguy merged commit 3fba86a into macports:master Nov 10, 2021
@mascguy mascguy deleted the mascguy-darktable branch November 10, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MarcusCalhoun-Lopez MarcusCalhoun-Lopez

Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update
Milestone
No milestone
3 participants
@mascguy @macportsbot @MarcusCalhoun-Lopez