Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensmtpd: Use OpenSSL portgroup #12843

Merged
merged 1 commit into from Nov 7, 2021
Merged

Conversation

ryanakca
Copy link
Contributor

@ryanakca ryanakca commented Nov 7, 2021

Description

Use OpenSSL portgroup instead of explicit dependency.

This requires a revision bump because of the transition from openssl 1.1
to openssl 3 behivd the scenes. This accomplishes what #12807 tried to
do.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.6 20G165 x86_64
Xcode 13.1 13A1030d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

This requires a revision bump because of the transition from openssl 1.1
to openssl 3 behivd the scenes.
@reneeotten
Copy link
Contributor

this does not make effectively no change whatsoever, you're adding the openssl PG and using the -now- default version 3. That's the same as just keeping the openssl dependency as that is now also switched to v3.

@ryanakca
Copy link
Contributor Author

ryanakca commented Nov 7, 2021

this does not make effectively no change whatsoever, you're adding the openssl PG and using the -now- default version 3. That's the same as just keeping the openssl dependency as that is now also switched to v3.

Are you suggesting that I didn't need to bump the revision? (Sorry, the double negative has me confused.)

@reneeotten
Copy link
Contributor

reneeotten commented Nov 7, 2021

this does not make effectively no change whatsoever, you're adding the openssl PG and using the -now- default version 3. That's the same as just keeping the openssl dependency as that is now also switched to v3.

Are you suggesting that I didn't need to bump the revision? (Sorry, the double negative has me confused.)

sorry, that wasn't very clear indeed ;) What I mean is that this PR is not needed as it doesn't change anything; now that the other PR is merged this port will use openssl3 regardless of this PR

@ryanakca
Copy link
Contributor Author

ryanakca commented Nov 7, 2021

Right, and there's no need or general desire to switch from explicit dependencies to the OpenSSL port group? If that's the case, then please feel free to close the PR.

@reneeotten
Copy link
Contributor

eventually transitioning to the openssl PG is probably a good idea if there are newer versions of openssl released. So it's fine with me and I'll just merge this PR (just wanted to point out that right now it doesn't really change anything).

@reneeotten reneeotten merged commit d88ffc0 into macports:master Nov 7, 2021
@ryanakca ryanakca deleted the opensmtpd branch November 7, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants