nodejs16/17: link against system zlib #12996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #63774 Revbumping because the prior version would build successfully, but the statically linked zlib code never worked on Monterey.
Revbumping because the prior version would build successfully, but the statically linked zlib code never worked on Monterey.
|
Notifying maintainers: |
mascguy
approved these changes
Nov 24, 2021
|
Folks have had eight days to provide feedback, so merging. |
11 tasks
rhapsodyv
added a commit
to rhapsodyv/macports-ports
that referenced
this pull request
Feb 22, 2022
Fixes zlib issue with nodejs 12 and 14, linking against system zlib. Same of https://trac.macports.org/ticket/63774 and macports#12996, but for nodejs 12 and 14.
reneeotten
pushed a commit
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://trac.macports.org/ticket/63774
My guess is that some code from Node's variant of zlib is getting optimised incorrectly with the new Apple Clang version, but I did not look into it much. Normally we link against system libs anyway, and this fixes the issue we are having.
Also there are more opportunties for system lib linking:
Only bumping these two versions as these are the versions supported around the time of Monterey's release and only Monterey is affected by the zlib static code issue.
Revbump is to force a rebuild for those affected (and unfortunately those who aren't, but I have never seen
revisionused conditionally).I do not know how far back the patch should go if we decide to patch nodejs15 and before that. However, linking against system libs is still seen as an improvement.
Type(s)
Tested on
macOS 12.0.1 21A559 x86_64
Xcode 13.1 13A1030d
Verification
Have you
port lint?sudo port -vst install?