Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfgrep: Update to 2.1.2 and fix build on <= 10.7 #13234

Merged
merged 1 commit into from Dec 10, 2021

Conversation

ryandesign
Copy link
Contributor

Closes: https://trac.macports.org/ticket/62108

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.7.5
Xcode 4.6.3

macOS 10.15.6
Xcode 12.4

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@raimue for port pdfgrep.

@raimue
Copy link
Member

raimue commented Dec 3, 2021

Oh, this actually works on OS X 10.7? I still maintain pdfgrep-legacy which was intended for OS X <= 10.8 because of missing C++ features. I guess we could now mark it replaced_by?

@reneeotten
Copy link
Contributor

is this waiting for anything or can it be merged?

@ryandesign
Copy link
Contributor Author

this actually works on OS X 10.7?

I verified it built on 10.7 and 10.15, and IIRC I ran the --version command or whatever and verified that its output looked sensible.

@raimue
Copy link
Member

raimue commented Dec 10, 2021

Okay, thanks, let's merge it then. Removing pdfgrep-legacy can still happen at a later point.

@raimue raimue merged commit 2c827c6 into macports:master Dec 10, 2021
@ryandesign ryandesign deleted the pdfgrep branch December 11, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants