git: do not overwrite system-wide gitconfig, when adding configuration for the osxkeychain credential helper #13259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying maintainers: |
macportsbot
added
by: member
herbygillot
force-pushed
the
git-no-override-gitconfig
branch
from
36656e6
to
d2b2f72
Compare
…tion for the osxkeychain credential helper If the gitconfig does not exist, then it will be created. But if it *does* exist, then the file will be checked to see whether it already contains the desired config, and if it doesn't, the configuration will be appended to the already existing file. Fixes: https://trac.macports.org/ticket/63953
herbygillot
force-pushed
the
git-no-override-gitconfig
branch
from
d2b2f72
to
1b41a32
Compare
mascguy
approved these changes
Dec 7, 2021
mascguy
changed the title
|
LGTM. And this will certainly be appreciated by users who rely on customization to the system config. Great work Herby! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not overwrite the system-wide gitconfig when adding configuration for the osxkeychain credential helper
If the gitconfig does not exist, then it will be created. But if it does
exist, then the file will be checked to see whether it already contains the
desired config, and if it doesn't, the configuration will be appended to the
already existing file.
Fixes: https://trac.macports.org/ticket/63953
Verification
Have you
port lint?sudo port test?sudo port -d install?