Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-pytorch: Fix build issue by using google-glog version 0.4.0 #13632

Merged
merged 3 commits into from Feb 13, 2022

Conversation

essandess
Copy link
Contributor

Fixes: https://trac.macports.org/ticket/63544
See: pytorch/pytorch#58054

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.1 21C52 x86_64
Xcode 13.2.1 13C100

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@reneeotten
Copy link
Contributor

@essandess it seems that this still isn't fixed upstream, correct? Are the CI failures just timeouts and does this all work as you want it locally - if so, I'll just merge this PR.

@essandess
Copy link
Contributor Author

@essandess it seems that this still isn't fixed upstream, correct? Are the CI failures just timeouts and does this all work as you want it locally - if so, I'll just merge this PR.

Yes, the issue is still open, I tested against 1.10.1, and 1.10.2 is out now, but this issues doesn't appear to be addressed yet.

I'd recommend merging just to get a working version. Yes, all the CI error are simple timeouts.

@reneeotten reneeotten merged commit 1664788 into macports:master Feb 13, 2022
@essandess essandess deleted the py-pytorch branch March 10, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants