Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: ad-hoc patches to make 28.1 compile on old macOS boxes #14594

Merged
merged 1 commit into from Apr 17, 2022

Conversation

lemzwerg
Copy link
Contributor

Description

See thread starting at

https://lists.gnu.org/archive/html/emacs-devel/2022-04/msg00779.html

As mentioned there, it still doesn't work on my Lion box. However, with these patches the old macOS computers in the build farm can proceed, I hope, and check whether it is a local problem or a generic one.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.7.5 11G63 x86_64
Xcode 4.6.3 4H1503

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@drkp for port emacs.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port type: bugfix labels Apr 16, 2022
See thread starting at

  https://lists.gnu.org/archive/html/emacs-devel/2022-04/msg00779.html

As mentioned there, it still doesn't work on my Lion box.  However, with
these patches the old macOS computers in the build farm can proceed and
check whether it is a local problem or a generic one.

Also update 'emacs-devel', since some patches have already been committed
upstream.
@lemzwerg
Copy link
Contributor Author

@kencu, could you trigger a build on Lion, please?

@kencu
Copy link
Contributor

kencu commented Apr 16, 2022

Hi @lemzwerg - as it turns out, the github PR setup and MacPorts' buildbots don't really work that way.

What one must do is commit it, then the buildbots will start their run.

@lemzwerg
Copy link
Contributor Author

OK, thanks for the info. Well, then I can only wait :-)

@drkp drkp merged commit 794b8b4 into macports:master Apr 17, 2022
@drkp
Copy link
Contributor

drkp commented Apr 17, 2022

Thanks! As I mentioned, I don't have a 10.7 machine anymore, so I can't test that specifically. Let's see how this look on the buildbots though...

@lemzwerg
Copy link
Contributor Author

Just a heads-up that I didn't change the revision in the Portfile, in case this matters.

@dmfunk
Copy link

dmfunk commented May 18, 2022

Hey there,

I'm running OS X 10.7.5, on a MacBook 2,1.

I was previously able to compile emacs 27.2 in two flavours (emacs-app && emacs-mac-app)

both fail @ 28.1, however.

Attached is main.log from $ sudo port install emacs-mac-app

28.1_10.7.5_main.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
5 participants