Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got: submission (new Portfile) Game of Trees 0.69 #14722

Merged
merged 2 commits into from May 6, 2022
Merged

got: submission (new Portfile) Game of Trees 0.69 #14722

merged 2 commits into from May 6, 2022

Conversation

artkiver
Copy link
Contributor

Closes: https://trac.macports.org/ticket/65059

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.3.1 21E258 arm64
Xcode 13.3.1 13E500a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@herbygillot
Copy link
Member

Thanks for this submission @artkiver - I was going to comment that you could replace the path:lib/libssl.dylib:openssl dependency with the OpenSSL portgroup, then realized that perhaps one may want the option to use libressl. Besides the comment above, this looks good.

Co-authored-by: Herby Gillot <herby.gillot@gmail.com>
@artkiver
Copy link
Contributor Author

artkiver commented May 6, 2022

My apologies for the delayed reply, I haven't been near a keyboard much in the past week due to a lot of "life" happening. The revision field change looks good and hopefully I clicked the correct button to commit that change. As you observed, the dylib stanza is preferable as it facilitates the use of libressl for example (my initial Portfile [not submitted as a PR] actually specified LibreSSL explicitly, but I opted for the dynamic library approach to make it easier for those who may still be attached to OpenSSL or other TLS libraries).

@herbygillot herbygillot merged commit 81d77f1 into macports:master May 6, 2022
@herbygillot
Copy link
Member

Thanks @artkiver. This created a second commit and we usually like all changes to be a single commit. I've resolved this by squashing the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants