libxc5: new port (new version of libxc) #14889

barracuda156 · 2022-05-19T20:02:12Z

Description

Latest versions of libxc missing in Macports. Added new segregated versions, which don't conflict with earlier versions.
(Universal variant does build on Leopard, unlike with earlier versions of libxc, therefore muniversal PG.)

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.6 PPC (10A190)
Xcode 3.2

macOS 10.5.8
Xcode 3.1.4

Verification

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?
checked your Portfile with port lint --nitpick?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

macportsbot · 2022-05-19T20:02:15Z

Notifying maintainers:
@dstrubbe for port libxc, libxc4.

barracuda156 · 2022-05-20T00:15:06Z

If anyone can say why macos-11 bot fails, would be great. Everything else, apparently, builds fine.

barracuda156 · 2022-09-20T12:38:21Z

@mascguy Could you say why it fails specifically on MacOS-11 bot (10.15 and 12 are both fine, as well as 10.6.8)? Moreover, looking at the log, build is okay, but something weird happens only at destroot:
https://github.com/macports/macports-ports/actions/runs/3090030319/jobs/4998326448#step:8:3559

mascguy · 2022-09-20T12:42:57Z

@mascguy Could you say why it fails specifically on MacOS-11 bot (10.15 and 12 are both fine, as well as 10.6.8)? Moreover, looking at the log, build is okay, but something weird happens only at destroot: https://github.com/macports/macports-ports/actions/runs/3090030319/jobs/4998326448#step:8:3559

It looks like Clang is crashing with a segfault, during compilation.

barracuda156 · 2022-09-20T12:46:43Z

@mascguy With libxc5 I see in the log it reaches up to destroot and fails there (on MacOS-11):

make: Leaving directory `/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_science_libxc5/libxc5/work/build'
  DEBUG: Executing portdestroot::destroot_finish
  DEBUG: Fixing glibtool .la files in destroot for libxc5
  DEBUG: checking for mtree violations
  DEBUG: dropping privileges: euid changed to 502, egid changed to 501.
  DEBUG: install phase started at Tue Sep 20 12:34:14 UTC 2022
 --->  Installing libxc5 @5.2.3_0

--->  Activating libxc5 @5.2.3_0

  DEBUG: Executing org.macports.load (libxc5)
  /Users/runner/work/_temp/909da96c-1975-482d-a124-f00a2fe9ec01.sh: line 4: 19263 Terminated: 15          tail -f "$workdir/logs/dependencies-progress.txt" 2> /dev/null

barracuda156 · 2022-09-20T12:55:20Z

BTW, need to blacklist Clang for ppc, this fails badly:

clang: warning: not using the clang compiler for the 'powerpc' architecture
clang: warning: argument unused during compilation: '-march=native'
[ 51%] Building C object CMakeFiles/xc.dir/src/hyb_gga_x_cam_s12.c.o
/usr/bin/clang -DHAVE_CBRT -DXC_DONT_COMPILE_KXC -DXC_DONT_COMPILE_LXC -DXC_ENFORCE_FERMI_HOLE_CURVATURE -I/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src -I/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/build/src -I/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/build -pipe -Os -DNDEBUG -I/opt/local/include -march=native -arch ppc -mmacosx-version-min=10.6 -fPIC -o CMakeFiles/xc.dir/src/hyb_gga_x_cam_s12.c.o -c /opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_x_cam_s12.c
clang: warning: not using the clang compiler for the 'powerpc' architecture
clang: warning: argument unused during compilation: '-march=native'
[ 51%] Building C object CMakeFiles/xc.dir/src/hyb_gga_xc_case21.c.o
/usr/bin/clang -DHAVE_CBRT -DXC_DONT_COMPILE_KXC -DXC_DONT_COMPILE_LXC -DXC_ENFORCE_FERMI_HOLE_CURVATURE -I/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src -I/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/build/src -I/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/build -pipe -Os -DNDEBUG -I/opt/local/include -march=native -arch ppc -mmacosx-version-min=10.6 -fPIC -o CMakeFiles/xc.dir/src/hyb_gga_xc_case21.c.o -c /opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c
clang: warning: not using the clang compiler for the 'powerpc' architecture
clang: warning: argument unused during compilation: '-march=native'
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c: In function ‘xbspline’:
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c:52: error: ‘for’ loop initial declaration used outside C99 mode
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c: In function ‘cbspline’:
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c:65: error: ‘for’ loop initial declaration used outside C99 mode
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c: In function ‘case21_set_ext_params’:
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c:86: error: ‘for’ loop initial declaration used outside C99 mode
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c:93: error: ‘for’ loop initial declaration used outside C99 mode
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c:95: error: redefinition of ‘i’
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c:93: error: previous definition of ‘i’ was here
/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/libxc-5.2.3/src/hyb_gga_xc_case21.c:95: error: ‘for’ loop initial declaration used outside C99 mode
make[2]: *** [CMakeFiles/xc.dir/src/hyb_gga_xc_case21.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/build'
make[1]: *** [CMakeFiles/xc.dir/all] Error 2
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_PPCRosettaPorts_science_libxc5/libxc5/work/build'
make: *** [all] Error 2

Will add it.

mascguy · 2022-09-20T12:59:09Z

It looks like Clang is crashing with a segfault, during compilation.

To clarify, this is occurring for libcx4.

barracuda156 · 2022-09-20T13:04:23Z

It looks like Clang is crashing with a segfault, during compilation.

To clarify, this is occurring for libcx4.

@mascguy I did not do anything to that port, just added conflict with libcx5.

mascguy · 2022-09-20T13:06:12Z

It looks like Clang is crashing with a segfault, during compilation.

To clarify, this is occurring for libcx4.

@mascguy I did not do anything to that port, just added conflict with libcx5.

Whether you modified it or not, is inconsequential: You asked why CI is failing, and I answered the question.

How we actually resolve it, is another story.

barracuda156 · 2022-09-20T13:10:01Z

@mascguy Fair enough. Should I try fixing libcx4? Or this issue can be considered separate from the present PR (and libcx5 builds fine)?

mascguy · 2022-09-20T13:22:32Z

@mascguy Fair enough. Should I try fixing libcx4? Or this issue can be considered separate from the present PR (and libcx5 builds fine)?

For now, focus on wrapping up your other PRs, which don't have such issues. We'll revisit this one later.

mascguy · 2023-05-21T00:43:28Z

For this one, you'll want to make libxc5 a new segregated port, that doesn't conflict. We'll ultimately want to segregate libxc4 as well, but I can tackle that separately.

barracuda156 · 2023-05-21T08:05:49Z

For this one, you'll want to make libxc5 a new segregated port, that doesn't conflict. We'll ultimately want to segregate libxc4 as well, but I can tackle that separately.

I will try to sort this out tomorrow.

UPD. Turned out, there is v. 6 already :)

barracuda156 · 2023-05-24T18:40:07Z

@mascguy In principle, we want to place all those libxc versions into /libexec and then modify .pc files (or whatever they install) accordingly?

mascguy · 2023-05-24T18:45:54Z

@mascguy In principle, we want to place all those libxc versions into /libexec and then modify .pc files (or whatever they install) accordingly?

Yep, exactly!

mascguy · 2023-05-24T18:50:43Z

@mascguy In principle, we want to place all those libxc versions into /libexec and then modify .pc files (or whatever they install) accordingly?

Yep, exactly!

Well, no, there's no need to modify the pkgconfig files. The ports should simply be rooted under libexec - including the pkgconfigs - and then dependents would need to be updated to know about them.

As an example, ffmpeg-upstream:

Click to Expand

Port ffmpeg-upstream contains:
  /opt/local/libexec/ffmpeg6/bin/ffmpeg
  /opt/local/libexec/ffmpeg6/bin/ffplay
  /opt/local/libexec/ffmpeg6/bin/ffprobe
  /opt/local/libexec/ffmpeg6/include/libavcodec/ac3_parser.h
  /opt/local/libexec/ffmpeg6/include/libavcodec/adts_parser.h
  /opt/local/libexec/ffmpeg6/include/libavcodec/avcodec.h
[...many more headers snipped...]
  /opt/local/libexec/ffmpeg6/lib/libavcodec.60.3.100.dylib
  /opt/local/libexec/ffmpeg6/lib/libavcodec.60.dylib
  /opt/local/libexec/ffmpeg6/lib/libavcodec.a
[...many more libs snipped...]
  /opt/local/libexec/ffmpeg6/lib/pkgconfig/libavcodec.pc
  /opt/local/libexec/ffmpeg6/lib/pkgconfig/libavdevice.pc
  /opt/local/libexec/ffmpeg6/lib/pkgconfig/libavfilter.pc
[...many more pkgconfigs snipped...]
  /opt/local/libexec/ffmpeg6/share/data/examples/Makefile
  /opt/local/libexec/ffmpeg6/share/data/examples/README
  /opt/local/libexec/ffmpeg6/share/data/examples/avio_http_serve_files.c
[...many more examples snipped...]
  /opt/local/libexec/ffmpeg6/share/doc/APIchanges
  /opt/local/libexec/ffmpeg6/share/doc/bootstrap.min.css
  /opt/local/libexec/ffmpeg6/share/doc/build_system.txt
[...lots of other docs snipped...]

mascguy · 2023-05-25T15:55:43Z

FYI, it looks like upstream is up to version 6. (6.1.0 presently.) So you might want to either create another segregated port for that too, following the same pattern you end up using for libxc5.

barracuda156 · 2023-05-25T21:49:53Z

FYI, it looks like upstream is up to version 6. (6.1.0 presently.) So you might want to either create another segregated port for that too, following the same pattern you end up using for libxc5.

Yes, I wrote about that above #14889 (comment)

barracuda156 · 2023-05-26T14:29:50Z

Build of libxc6 is fine, need to add a fix for tests, otherwise they try to link to prefix.

barracuda156 · 2023-05-26T15:45:02Z

@mascguy I will run tests now. Builds confirmed, though for libxc5 we need to check if the patch does what it should. Otherwise it places cmake configs into a random directory.

UPD. Yes, patch is fine, now everything is installed into ${prefix}/libexec/${name}.

UPD2. Nop, libxc5 is still doing something wrong:

Could not open /opt/local/lib/libxc.9.dylib: Error opening or reading file (referenced from /opt/local/libexec/libxc5/bin/xc-info)

Will look into this.
Hmm, that file should not be there at all – after upgrade of the port. May not be an installation issue. Let me remove the port completely and rebuild anew.

barracuda156 · 2023-05-26T15:59:29Z

@mascguy CI fail, as before, on libxc4, which is as such unrelated to this PR.

barracuda156 · 2023-05-26T16:30:04Z

UPD3. Tests pass for libxc6:

            Start 19154: Libxc-hyb_mgga_xc_xb1k-Li-unpol-1-check
19154/19154 Test #19154: Libxc-hyb_mgga_xc_xb1k-Li-unpol-1-check ................   Passed    0.02 sec

100% tests passed, 0 tests failed out of 19154

Total Test time (real) = 384.61 sec

libxc5 needs a fix for that dylib.

mascguy · 2023-05-26T16:38:04Z

@mascguy CI fail, as before, on libxc4, which is as such unrelated to this PR.

Well, now you can drop your commits for libxc and libxc4, as your new segregated ports don't conflict with them.

barracuda156 · 2023-05-26T16:45:06Z

@mascguy CI fail, as before, on libxc4, which is as such unrelated to this PR.

Well, now you can drop your commits for libxc and libxc4, as your new segregated ports don't conflict with them.

Indeed. Will do that. Let me also fix that annoying dylib in libxc5, something is setting the wrong path for it. And then hopefully we are done.

mascguy

LGTM

mascguy · 2023-05-26T17:01:04Z

One more old PR merged, let's keep the momentum going Sergey!

barracuda156 · 2023-05-26T17:04:50Z

I think we still need a fix for that dylib, but I will test on another machine now.

P. S. By the way, libheif still broken – we need to condition clang-specific flags on actually clang being used (or libcxx?), not on OS version. These are compiler flags, right? Not linker ones. They will fail with GCC on newer systems, I believe, just as they fail on 10.6.

mascguy · 2023-05-26T17:06:36Z

UPD2. Nop, libxc5 is still doing something wrong:
Could not open /opt/local/lib/libxc.9.dylib: Error opening or reading file (referenced from /opt/local/libexec/libxc5/bin/xc-info)
Will look into this. Hmm, that file should not be there at all – after upgrade of the port. May not be an installation issue. Let me remove the port completely and rebuild anew.

This should only occur when libxc is already installed, so it won't occur on the buildbots. Nonetheless, I'll take care of fixing.

See: #14889 (comment)

- Add missing revision See: #14889

See: #14889

macportsbot assigned dstrubbe May 19, 2022

macportsbot added maintainer: requires approval type: enhancement type: submission labels May 19, 2022

macportsbot added the maintainer: timeout label May 23, 2022

mascguy marked this pull request as draft July 13, 2022 21:18

barracuda156 force-pushed the libxc5 branch from 0532703 to 548d1e7 Compare September 20, 2022 12:16

mascguy force-pushed the libxc5 branch from 5341066 to 39759e0 Compare May 24, 2023 18:34

barracuda156 force-pushed the libxc5 branch from 1610c18 to db7f785 Compare May 26, 2023 15:43

mascguy force-pushed the libxc5 branch from db7f785 to 984c328 Compare May 26, 2023 16:45

barracuda156 added 2 commits May 26, 2023 12:47

libxc5, new version of libxc

55c165d

libxc6: new version of libxc

1fa6129

mascguy force-pushed the libxc5 branch from 984c328 to 1fa6129 Compare May 26, 2023 16:47

mascguy marked this pull request as ready for review May 26, 2023 16:47

mascguy approved these changes May 26, 2023

View reviewed changes

mascguy merged commit e98deca into macports:master May 26, 2023
3 checks passed

barracuda156 deleted the libxc5 branch May 26, 2023 17:02

mascguy added a commit that referenced this pull request May 27, 2023

libxc{5,6}: add conflicts_build against libxc

3742d23

See: #14889 (comment)

mascguy added a commit that referenced this pull request May 29, 2023

libxc{5,6}: set dist_subdir to libxc; pin livecheck to ver major

d0a620f

- Add missing revision See: #14889

mascguy added a commit that referenced this pull request May 29, 2023

libxc6: update to 6.2.0

0773852

See: #14889

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libxc5: new port (new version of libxc) #14889

libxc5: new port (new version of libxc) #14889

barracuda156 commented May 19, 2022 •

edited by mascguy

macportsbot commented May 19, 2022

barracuda156 commented May 20, 2022

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022

barracuda156 commented Sep 20, 2022

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022 •

edited

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022

mascguy commented May 21, 2023

barracuda156 commented May 21, 2023 •

edited

barracuda156 commented May 24, 2023

mascguy commented May 24, 2023

mascguy commented May 24, 2023

mascguy commented May 25, 2023

barracuda156 commented May 25, 2023

barracuda156 commented May 26, 2023

barracuda156 commented May 26, 2023 •

edited

barracuda156 commented May 26, 2023

barracuda156 commented May 26, 2023

mascguy commented May 26, 2023

barracuda156 commented May 26, 2023

mascguy left a comment

mascguy commented May 26, 2023

barracuda156 commented May 26, 2023

mascguy commented May 26, 2023

libxc5: new port (new version of libxc) #14889

libxc5: new port (new version of libxc) #14889

Conversation

barracuda156 commented May 19, 2022 • edited by mascguy

Description

Type(s)

Tested on

Verification

macportsbot commented May 19, 2022

barracuda156 commented May 20, 2022

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022

barracuda156 commented Sep 20, 2022

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022 • edited

barracuda156 commented Sep 20, 2022

mascguy commented Sep 20, 2022

mascguy commented May 21, 2023

barracuda156 commented May 21, 2023 • edited

barracuda156 commented May 24, 2023

mascguy commented May 24, 2023

mascguy commented May 24, 2023

mascguy commented May 25, 2023

barracuda156 commented May 25, 2023

barracuda156 commented May 26, 2023

barracuda156 commented May 26, 2023 • edited

barracuda156 commented May 26, 2023

barracuda156 commented May 26, 2023

mascguy commented May 26, 2023

barracuda156 commented May 26, 2023

mascguy left a comment

Choose a reason for hiding this comment

mascguy commented May 26, 2023

barracuda156 commented May 26, 2023

mascguy commented May 26, 2023

barracuda156 commented May 19, 2022 •

edited by mascguy

mascguy commented Sep 20, 2022 •

edited

barracuda156 commented May 21, 2023 •

edited

barracuda156 commented May 26, 2023 •

edited