qmake5 PortGroup: improve sdk detection #14914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hide output from sdk-finding command
the xcrun command is supposed to fail if the specific
sdk macosx${configure.sdk_version} is not found. However,
this error shows up on user's screens causing considerable
confusion about what the true build error is.
- ensure sdk macosx is found if we are going to use it
|
I think it's right this time. I had to go learn some more tcl, specifically the ordering of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the xcrun command is supposed to fail if the specific
sdk macosx${configure.sdk_version} is not found. However,
this error shows up on user's screens causing considerable
confusion about what the true build error is.