Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddrescue: fix compilation error related to std::exit #15068

Merged
merged 2 commits into from Jun 7, 2022
Merged

ddrescue: fix compilation error related to std::exit #15068

merged 2 commits into from Jun 7, 2022

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Jun 5, 2022 •
edited

Description

File loggers.cc references std::exit, without including cstdlib. This works with some compilers, but not others.

Fixes: https://trac.macports.org/ticket/65300

Tested on

  • macOS 10.7
  • macOS 10.9
  • macOS 10.11

@macportsbot
Copy link

Notifying maintainers:
@raimue for port ddrescue.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: requires approval labels Jun 5, 2022
jmroot
jmroot requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@jmroot jmroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing compilers is not the right fix for a missing include.

@mascguy mascguy changed the title ddrescue: blacklist clang < 900 ddrescue: fix compilation error related to std::exit Jun 6, 2022
@mascguy
Copy link
Member Author

mascguy commented Jun 6, 2022

Changing compilers is not the right fix for a missing include.

PR updated

@mascguy mascguy requested a review from jmroot June 6, 2022 20:54
@mascguy
Copy link
Member Author

mascguy commented Jun 6, 2022

Retested on 10.7, 10.9, and 10.11, with latest approach. And looks good on all three.

@mascguy
Copy link
Member Author

mascguy commented Jun 7, 2022

@raimue Rainer, are you good with merging?

raimue
raimue approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@raimue raimue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@mascguy mascguy merged commit 89bb5b4 into macports:master Jun 7, 2022
@mascguy mascguy deleted the mascguy-ddrescue branch June 7, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimue raimue raimue approved these changes

@jmroot jmroot jmroot approved these changes

Assignees

@raimue raimue

Labels
by: member Created by a member with commit rights maintainer: requires approval
Milestone
No milestone
4 participants
@mascguy @macportsbot @raimue @jmroot