New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libuv: update to 1.44.2 #15359
libuv: update to 1.44.2 #15359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Michael, should we merge as-is, or are you interested in making other changes first?
@mascguy My |
@barracuda156 does this PR build for you on any PPC? If so, then let's do the merge. Thx! |
@mascguy I wanted to let CI/QA run & also give @kencu & @barracuda156 a chance to test on older OSX. QA/CI here looks good. Once we get some feedback & assuming it's positive then let's merge. If not positive, then we can decide whether to fix first them merge or just merge & fix later. Given these quite old OSX, there won't be a lot of users impacted, but as long as it doesn't take too much time I'm fine with the short delay. I'll merge Monday July 18 if no comment one way or the other. |
@michaelld Sorry, I cannot verify that presently, as I am away from all my PPC hardware until last week of August. |
@evanmiller Evan, would you be interested in quickly testing this on PPC? I'm happy to do so as well, though I'm inclined to defer to you and Sergey. (Simply because you folks have much more experience in that area!) |
Builds fine for me, on 10.5 PPC. |
@mascguy What about |
I only have a 32-bit PPC machine, so can't help with that! LOL |
Ah, got it. Well, then I’ll test it later, but we should be good. Thank you for checking on 10.5 PPC! |
Just for an update, on 10.6.8 Rosetta On my end I still added the following to be on a safe side:
|
apologies for not getting back to you about this, Michael… looks like everyone pitched it! |
Description
libuv: update to 1.44.2
Type(s)
Tested on
macOS 11.6.8 20G725
Xcode 12.3 12C33
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?