Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: update to 1.44.2 #15359

Merged
merged 1 commit into from Jul 14, 2022
Merged

Conversation

michaelld
Copy link
Contributor

Description

libuv: update to 1.44.2

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.6.8 20G725
Xcode 12.3 12C33

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer maintainer: open Affects an openmaintainer port type: enhancement type: update labels Jul 13, 2022
Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Michael, should we merge as-is, or are you interested in making other changes first?

@barracuda156
Copy link
Contributor

LGTM.

@mascguy My ppc64 patch got included in the master, so it is redundant. Re over patches I will update next month. Perhaps @evanmiller may confirm if ppc build succeeds on Tiger.

@michaelld michaelld requested a review from kencu July 14, 2022 14:31
@michaelld
Copy link
Contributor Author

@barracuda156 does this PR build for you on any PPC? If so, then let's do the merge. Thx!

@michaelld
Copy link
Contributor Author

@mascguy I wanted to let CI/QA run & also give @kencu & @barracuda156 a chance to test on older OSX. QA/CI here looks good. Once we get some feedback & assuming it's positive then let's merge. If not positive, then we can decide whether to fix first them merge or just merge & fix later. Given these quite old OSX, there won't be a lot of users impacted, but as long as it doesn't take too much time I'm fine with the short delay. I'll merge Monday July 18 if no comment one way or the other.

@barracuda156
Copy link
Contributor

@barracuda156 does this PR build for you on any PPC? If so, then let’s do the merge. Thx!

@michaelld Sorry, I cannot verify that presently, as I am away from all my PPC hardware until last week of August.
I have no objections to merging this PR though – let everyone benefit from the updated version, and if it happens to fail for ppc or ppc64, I will fix that in another PR next month.

@mascguy
Copy link
Member

mascguy commented Jul 14, 2022

@evanmiller Evan, would you be interested in quickly testing this on PPC?

I'm happy to do so as well, though I'm inclined to defer to you and Sergey. (Simply because you folks have much more experience in that area!)

@mascguy
Copy link
Member

mascguy commented Jul 14, 2022

Builds fine for me, on 10.5 PPC.

@barracuda156
Copy link
Contributor

Builds fine for me, on 10.5 PPC.

@mascguy What about ppc64?

@mascguy
Copy link
Member

mascguy commented Jul 14, 2022

@mascguy What about ppc64?

I only have a 32-bit PPC machine, so can't help with that! LOL

@barracuda156
Copy link
Contributor

@mascguy What about ppc64?

I only have a 32-bit PPC machine, so can't help with that! LOL

Ah, got it. Well, then I’ll test it later, but we should be good. Thank you for checking on 10.5 PPC!

@mascguy mascguy merged commit 998791c into macports:master Jul 14, 2022
@barracuda156
Copy link
Contributor

Just for an update, on 10.6.8 Rosetta libuv has built fine. While recognized triple was wrong, apparently it still built correctly.

On my end I still added the following to be on a safe side:

platform darwin 10 {
# This is a fix for Rosetta
    if {${build_arch} eq "ppc"} {
        configure.args-append --build=powerpc-apple-darwin10
    }
}

@kencu
Copy link
Contributor

kencu commented Jul 18, 2022

apologies for not getting back to you about this, Michael… looks like everyone pitched it!

@michaelld michaelld deleted the libuv_update_to_1.44.2 branch July 19, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: enhancement type: update
5 participants