Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtheora: fix build on Rosetta #15580

Merged
merged 1 commit into from Aug 4, 2022
Merged

libtheora: fix build on Rosetta #15580

merged 1 commit into from Aug 4, 2022

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Aug 3, 2022 •
edited

Description

Fixes build on Rosetta: https://trac.macports.org/ticket/64607

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 Server
Xcode 3.2.6

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@barracuda156
Copy link
Contributor Author

@mascguy Could you check this, please?

@mascguy
Copy link
Member

mascguy commented Aug 4, 2022

@mascguy Could you check this, please?

Looks good, though you'll want to update the commit message to auto-close the associated ticket.

@barracuda156
Copy link
Contributor Author

@mascguy Could you check this, please?

Looks good, though you'll want to update the commit message to auto-close the associated ticket.

Yes, will do now. Thank you.

@mascguy mascguy merged commit f706879 into macports:master Aug 4, 2022
@barracuda156 barracuda156 deleted the libtheora branch August 4, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mascguy mascguy mascguy approved these changes

Assignees
No one assigned
Labels
maintainer: none type: bugfix
Milestone
No milestone
3 participants
@barracuda156 @mascguy @macportsbot