Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper: update to 3.3.0 #16463

Merged
merged 1 commit into from Nov 8, 2022
Merged

hyper: update to 3.3.0 #16463

merged 1 commit into from Nov 8, 2022

Conversation

herbygillot
Copy link
Member

Fixes: https://trac.macports.org/ticket/65020

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer maintainer: open Affects an openmaintainer port type: update labels Oct 25, 2022
@herbygillot
Copy link
Member Author

@reneeotten

@pmetzger
Copy link
Member

pmetzger commented Nov 5, 2022

@reneeotten ?

@reneeotten
Copy link
Contributor

I commented in the associated Trac ticket - the issue regarding the compiler still persists

@herbygillot
Copy link
Member Author

herbygillot commented Nov 6, 2022

I spent some time on this, and had zero success convincing node_gyp to use a given compiler. node_gyp is the framework that deals with interfacing between Javascript and C/C++ in the build process. I think we should just update this port to its latest and deal with the compiler issue some other time.

@reneeotten
Copy link
Contributor

thanks @herbygillot - fine with me!

@reneeotten reneeotten merged commit e14d08e into macports:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: update
4 participants