Allow installing both port:tbb and port:onetbb

[catap]

Description

Here a PR on which I've worked for last weeks.

The goal is allow to install both tbb and onetbb port on the same machine, and it forces to add installing both oce and opencascade.

It is based on serveral PRs which I've made and which's fixed broken ports:

• onetbb: fix +universal build on macOS 10.6 #16866
• opencascade: update to 7.7.0 ; gmsh: update to 4.11.0; deal.ii: update to 9.4.0 #16876
• freecad: fix build #16888
• blender: update to 2.93.11 #16893
• bowtie: update to 1.3.1; bowtie2: update to 2.5.0 #16899
• netgen: update to 6.2.2204 #16912
• py-numba: update to 0.57.0rc1; py-llvmlite: update to 0.40.0rc1; add py311; remove py37  #18388

To be clear: only the last 3 commits are new.

Thus, I've skip CI because it had no chance to rebuild everything in 6 hours.

Type(s)

• bugfix
• enhancement

Tested on

macOS 12.6 21G115 x86_64
Xcode 14.1 14B47b

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@mbrethen for port freecad, oce.
@MarcusCalhoun-Lopez for port opencolorio, openimageio, openvdb, deal.ii, netgen, bowtie, bowtie2, getdp, gmsh, opencascade.
@neverpanic for port gerbil.
@mojca for port root6.
@stromnov for port rocksdb, opencv4-devel, opencv4, py-numba.
@mohd-akram for port onedpl, onetbb.
@jasonliu-- for port blender, embree, materialx, oidn, opensubdiv, openvdb, osl, partio, usd.
@mascguy for port opencv3-devel, opencv3, opencv4-devel, opencv4.
@reneeotten for port vtk-m.
@davidnich for port qore.
@cjones051073 for port py-mkl, root6.
@ra1nb0w for port kicad.
@mdave for port nektarpp.

[mascguy]

Very happy to see someone segregate the TBB ports, allowing them to finally co-exist. Ditto for updating the various ports.

Great stuff Kirill!

[mascguy]

I did a quick high-level review of the various Portfile changes, and added comments. But no serious concerns overall.

Anyone else?

[catap]

@mascguy thanks for review. Almost all commits from this PRs is parts from another ones which I've mentored inside the first commit.

It explains "wired" bump of revisions ;)

[catap]

All dependencies of this PR have been merged. So, it is ready.

@mascguy may I ask you to reivew it?

[catap]

Yahoo! Thanks @mascguy!

[catap]

I guess it was one of the longest PR that I've done so far :)

[mascguy]

I guess it was one of the longest PR that I've done so far :)

Great work as always Kirill, thank you for everything you do!

[mohd-akram]

I noticed this moved onetbb to libexec as well. Is this necessary since tbb is already moved there?

[mascguy]

I noticed this moved onetbb to libexec as well. Is this necessary since tbb is already moved there?

Yes, we need to move all versions to libexec, otherwise ports may inadvertently pick up onetbb when they want tbb.

[catap]

I noticed this moved onetbb to libexec as well. Is this necessary since tbb is already moved there?

and some magic in cmake level allows to not touch any port which is used OneTBB.

Thus, now we have ability to keep old version OneTBB for ports which for some reason need it.

[mascguy]

Kirill, I noticed one potential issue: It looks like the CMake files are being installed in two places, for onetbb. The segregated versions under libexec are fine, but they're also being placed in ${prefix}/lib/cmake:

Port onetbb contains:
  /opt/local/lib/cmake/TBB/TBBConfig.cmake
  /opt/local/lib/cmake/TBB/TBBConfigVersion.cmake
  /opt/local/lib/cmake/TBB/TBBTargets-macports.cmake
  /opt/local/lib/cmake/TBB/TBBTargets.cmake
[...]
  /opt/local/libexec/onetbb/lib/cmake/TBB/TBBConfig.cmake
  /opt/local/libexec/onetbb/lib/cmake/TBB/TBBConfigVersion.cmake
  /opt/local/libexec/onetbb/lib/cmake/TBB/TBBTargets-macports.cmake
  /opt/local/libexec/onetbb/lib/cmake/TBB/TBBTargets.cmake

[catap]

@mascguy it isn't an issue. It was made for propose. Why? To avoid supply each port with the path to the right OneTBB.

OneTBB is succesor of TBB and everyone should switch to it. And if you cat, for example, /opt/local/lib/cmake/TBB/TBBConfig.cmake you may see that it simple says:

include(/opt/local/libexec/onetbb/lib/cmake/TBB/TBBTargets.cmake)

:)

This migration is transparant for any port which is compatible with OneTBB and uses CMake. I assume it is majority of ports.