Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irrlichtmt: update #17161

Closed
wants to merge 1 commit into from
Closed

irrlichtmt: update #17161

wants to merge 1 commit into from

Conversation

Zweihorn
Copy link
Contributor

@Zweihorn Zweihorn commented Jan 1, 2023

This PR was made obsolete by #17241

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.7.2 20G1020 x86_64
Command Line Tools 13.2.0.0.1.1638488800

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@l2dy for port irrlichtmt.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port type: update labels Jan 1, 2023
@Zweihorn
Copy link
Contributor Author

Zweihorn commented Jan 1, 2023

@l2dy - I took the liberty to provide this as a little courtesy to a good teacher ...

@Zweihorn Zweihorn changed the title irrlcihtmt: update irrlichtMT9 (nine) irrlichtmt: update irrlichtMT9 (nine) Jan 1, 2023
@Zweihorn Zweihorn mentioned this pull request Jan 1, 2023
11 tasks
@Zweihorn Zweihorn marked this pull request as ready for review January 1, 2023 21:58
@l2dy
Copy link
Member

l2dy commented Jan 2, 2023

  • Make sure you could build minetest with this version of irrlichtmt.
  • Please follow the Commit Message Guidelines instead of using "update MT9".
  • if there is an ABI break, you would need to bump revision of the minetest port as well.

@Zweihorn
Copy link
Contributor Author

Zweihorn commented Jan 2, 2023

THX and I appreciate this.

  • Make sure you could build minetest with this version of irrlichtmt.

First things thirst I thought but I see your point.

First: What? - Second: Ah yes, my mishap. The "MT9" was the trailer to "irrlichtmt...9" but quite misleading. Sorry.

Reading (again) the a.m. Guidelines helped:
1 Subject (short)
2 Include the most important information (but concentrate on this)
3 Be specific. Avoid vague subjects like "Update to latest version" or "Fix the build". For example, if you are updating a port to a new upstream version, mention the version number. (be specific means: avoid ambiguity)
4 List any modified ports. (and keep blank if there are not any)

Mea culpa. Will learn and improve.

Next time something more concise like: "irrlichtmt: update"

  • if there is an ABI break, you would need to bump revision of the minetest port as well.

Good point. Wonder what @reneeotten might say to this rev bump but I am happy to oblige if anything with API breaks.

THX again.

@Zweihorn Zweihorn changed the title irrlichtmt: update irrlichtMT9 (nine) irrlichtmt: update Jan 2, 2023
@Zweihorn
Copy link
Contributor Author

Zweihorn commented Jan 2, 2023

How to sync with the "minetest" rev2 already in the queue?

@l2dy - IMO this update should be a task specific to "minetest" rev3 in due time.

@l2dy
Copy link
Member

l2dy commented Jan 2, 2023

How to sync with the "minetest" rev2 already in the queue?

@l2dy - IMO this update should be a task specific to "minetest" rev3 in due time.

I think you should make a PR with two commits, one updating irrlichtmt and the other bumping revision of minetest (and optionally include other changes to the port).

You could do this in your rev2 or rev3 PR, but remember to make the minetest commit on top of irrlichtmt update.

@Zweihorn Zweihorn marked this pull request as draft January 2, 2023 12:56
@Zweihorn
Copy link
Contributor Author

Zweihorn commented Jan 2, 2023

    irrlicht 1.9.0mt9 upstream
    bumped checksums
    Fix01: irrlichtmt fails to install on Mac OS 10.6 - ref https://trac.macports.org/ticket/66439
    Fix02: minetest arm64 support - ref https://trac.macports.org/ticket/66600
@Zweihorn
Copy link
Contributor Author

Zweihorn commented Jan 7, 2023

I think you should make a PR with two commits, one updating irrlichtmt and the other bumping revision of minetest (and optionally include other changes to the port).

You could do this in your rev2 or rev3 PR, but remember to make the minetest commit on top of irrlichtmt update.

I fear this is new to me and I already destroyed the earlier squash efforts somehow by help of git apparently.

Hold your breath, more chaos to come ...

@Zweihorn
Copy link
Contributor Author

Zweihorn commented Jan 7, 2023

The combined build and install has no problems with the new & amended 'irrlichtmt' API and 'minetest' was installed without any error.

#17153 (comment)

@Zweihorn Zweihorn closed this Jan 7, 2023
@Zweihorn Zweihorn deleted the irrlichtMT9 branch January 7, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
3 participants