Tweak workflow script #17774
Merged
Tweak workflow script #17774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only match files named exactly "Portfile", not other files whose names start with "Portfile".
Periods do not have the special meaning "any character" in character classes so there is no need to escape them there.
There does not seem to be any need to treat portlist as an array in this step since we only ever get the entire array here, and in subsequent steps we already treat it as string. Getting the entire array fails if there are no elements (i.e. if the commit only modified files that are not port files). See: https://trac.macports.org/ticket/62071
neverpanic
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweak workflow script for better accuracy and hopefully to address the error that occurs when no port files were modified (https://trac.macports.org/ticket/62071).
Type(s)