asciidoc: Fix documentation install directory #17933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for docdir is ${datarootdir}/doc/${PACKAGE_TARNAME}, and
while these have the values we expect them to have in the configure
script, this variable is left unexpanded and ${PACKAGE_TARNAME} is not
defined in the Makefile after Makefile generation, ends up empty, and
the documentation is installed in ${datarootdir}/doc. This is clearly
a bug, but I'm not sure whether it is in autoconf or asciidoc.
Closes: https://trac.macports.org/ticket/67081
macportsbot
added
type: bugfix
maintainer
maintainer: open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default for docdir is
${datarootdir}/doc/${PACKAGE_TARNAME}, and while these have the values we expect them to have in the configure script, this variable is left unexpanded and${PACKAGE_TARNAME}is not defined in the Makefile after Makefile generation, ends up empty, and the documentation is installed in${datarootdir}/doc. This is clearly a bug, but I'm not sure whether it is in autoconf or asciidoc.Closes: https://trac.macports.org/ticket/67081
Type(s)
Tested on
macOS 12.6.3 21G419 arm64
Xcode 14.2 14C18
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?