Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdal: update to version 2.5.2 #18060

Merged
merged 3 commits into from Apr 16, 2023
Merged

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Mar 22, 2023

Description

Upgrade PDAL to version 2.5.2

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.6.3 21G419 arm64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

I have tested with grass (8.2.1).

@nilason
Copy link
Contributor Author

nilason commented Mar 22, 2023

Port lint gives following error:
port lint PDAL: Error: Portfile directory pdal does not match port name PDAL
This is nothing caused by this version bump.
Should I address this here?

@nilason
Copy link
Contributor Author

nilason commented Mar 24, 2023

@Veence maybe you can take a look at this one and perhaps merge if OK?

@ryandesign
Copy link
Contributor

port lint PDAL: Error: Portfile directory pdal does not match port name PDAL
This is nothing caused by this version bump.

This was caused by e38c893. Veence should decide whether the port name should be PDAL (rename the directory) or pdal (fix the port name). All ports that depend on pdal should be confirmed to use the correct case after that decision is made.

@nilason
Copy link
Contributor Author

nilason commented Mar 28, 2023

port lint PDAL: Error: Portfile directory pdal does not match port name PDAL
This is nothing caused by this version bump.

This was caused by e38c893. Veence should decide whether the port name should be PDAL (rename the directory) or pdal (fix the port name). All ports that depend on pdal should be confirmed to use the correct case after that decision is made.

Personally, I'd prefer lower cased port name, in line with gdal, grass etc...

@reneeotten
Copy link
Contributor

well... I'll merge this PR for now because waiting until @Veence responds seems not practical

@reneeotten reneeotten merged commit f67c282 into macports:master Apr 16, 2023
2 checks passed
@nilason
Copy link
Contributor Author

nilason commented Apr 16, 2023

well... I'll merge this PR for now because waiting until @Veence responds seems not practical

Thanks!

@nilason nilason deleted the pdal_update_252 branch April 17, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants