gdal: update to 3.6.4 #18077

nilason · 2023-03-24T17:27:23Z

Description

Updates GDAL to version 3.6.3.

GDAL has dropped support for autotools, thus this is a complete remake to cmake.

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 12.6.3 21G419 arm64
Xcode 14.2 14C18

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?
checked your Portfile with port lint --nitpick?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?
checked that the Portfile's most important variants haven't been broken?

macportsbot · 2023-03-24T17:27:29Z

Notifying maintainers:
@Veence for port gdal.
@petrrr for port py-gdal.

nilason · 2023-03-26T20:24:23Z

Just noticed that there are two Python packages installed outside MacPorts directory in the CI build log:

/Library/Python/3.9/site-packages/osgeo/
/Library/Python/3.9/site-packages/osgeo_utils/

This didn't happen locally (it went to /opt/local/Library/Frameworks/Python.framework/Versions/3.11/...)

It is possible to configure which Python to use:
see GDAL docs for options.

I'm not sure what would be the correct or preferable way to detect and set specific Python version. I'd be grateful for any help on this!

nilason · 2023-03-26T21:05:05Z

Just noticed that there are two Python packages installed outside MacPorts directory in the CI build log:
/Library/Python/3.9/site-packages/osgeo/
/Library/Python/3.9/site-packages/osgeo_utils/
This didn't happen locally (it went to /opt/local/Library/Frameworks/Python.framework/Versions/3.11/...)

It is possible to configure which Python to use: see GDAL docs for options.

I'm not sure what would be the correct or preferable way to detect and set specific Python version. I'd be grateful for any help on this!

How silly I am, this is what py-gdal is for.

ryandesign

Just noticed that there are two Python packages installed outside MacPorts directory in the CI build log:
/Library/Python/3.9/site-packages/osgeo/
/Library/Python/3.9/site-packages/osgeo_utils/

You'll need to figure out how to get the build system to stop doing that.

gis/gdal-grass/Portfile

gis/gdal/Portfile

nilason · 2023-03-28T20:21:49Z

@ryandesign Thanks a lot for taking time on this! I think I addressed all you suggestions, issues.
I added a minor liblas update which I may remove if not appropriate in one PR.

nilason · 2023-03-28T22:00:50Z

Just noticed that there are two Python packages installed outside MacPorts directory in the CI build log:
/Library/Python/3.9/site-packages/osgeo/
/Library/Python/3.9/site-packages/osgeo_utils/
You'll need to figure out how to get the build system to stop doing that.

Setting -DBUILD_PYTHON_BINDINGS was needed to drop them.

nilason · 2023-03-31T06:38:10Z

@ryandesign What is the common practice here, shall I add a commit with revision bump of dependants?

nilason · 2023-04-03T17:21:33Z

@Veence Please take a look at this. GDAL update is long overdue.

nilason · 2023-04-15T08:35:20Z

gis/gdal-grass/Portfile

+    set grass_gisbase [exec ${prefix}/bin/grass --config path]

-configure.args-append   --with-gdal=${prefix}/bin/gdal-config
-configure.args-append   --with-grass=${prefix}/share/grass-7.4.0
+    configure.args-append --with-grass=${grass_gisbase}


Fixes https://trac.macports.org/ticket/64411

nilason · 2023-04-17T17:36:51Z

gis/gdal/Portfile

    "
 }

-variant mysql5 conflicts mysql57 mysql8 description {Enable MySQL 5 support} {


Addresses https://trac.macports.org/ticket/43431

nilason · 2023-04-20T12:45:18Z

gis/gdal/Portfile

+    PortGroup               boost 1.0

-    configure.args-delete   --without-grass
-    configure.args-append   --with-grass=${prefix}/share/grass78
+    depends_lib-append      port:libkml
+    boost.depends_type      build


Building with libkml driver requires include-path to boost. Not sure this is the best way to achieve this?

not sure exactly what is needed here, but the boost PG does set quite a few cmake related variables already (see here). If the gdal port needs another variable name the PG probably will provide the necessary hints to do so.
Also, since you're setting the dependency type to build it would be good to check that nothing links to boost package (i.e., is required at runtime).

It is not GDAL that uses boost, but libkml. The GDAL driver code includes libkml header files which in turn includes boost. GDAL expects the header files to be in standard ${prefix}/include and has no way to know to look into eg. ${prefix}/libexec/boost/1.76/include.

Also, since you're setting the dependency type to build it would be good to check that nothing links to boost package (i.e., is required at runtime).

GDAL doesn't seem to link (as its not using boost directly):

otool -L /opt/local/lib/gdalplugins/ogr_LIBKML.dylib /opt/local/lib/gdalplugins/ogr_LIBKML.dylib: @rpath/libgdal.32.dylib (compatibility version 32.0.0, current version 32.3.6) /opt/local/lib/libkmlbase.1.dylib (compatibility version 1.0.0, current version 1.3.0) /opt/local/lib/libkmldom.1.dylib (compatibility version 1.0.0, current version 1.3.0) /opt/local/lib/libkmlengine.1.dylib (compatibility version 1.0.0, current version 1.3.0) /opt/local/lib/libminizip.1.dylib (compatibility version 2.0.0, current version 2.0.0) /opt/local/lib/liburiparser.1.dylib (compatibility version 1.0.0, current version 1.0.30) /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.13) /opt/local/lib/libexpat.1.dylib (compatibility version 10.0.0, current version 10.10.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3) /opt/local/lib/openmpi-mp/libmpi_cxx.40.dylib (compatibility version 71.0.0, current version 71.1.0) /opt/local/lib/openmpi-mp/libmpi.40.dylib (compatibility version 71.0.0, current version 71.4.0) /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.23.0)

It is not GDAL that uses boost, but libkml. The GDAL driver code includes libkml header files which in turn includes boost. GDAL expects the header files to be in standard ${prefix}/include and has no way to know to look into eg. ${prefix}/libexec/boost/1.76/include.

that sounds strange to me... if gdal doesn't use boost then it shouldn't need to have it as a built dependency. If the libkml port uses boost then it should probably specify in that port where the boost headers are and gdal should be able to use those - or am I missing something here?

that sounds strange to me... if gdal doesn't use boost then it shouldn't need to have it as a built dependency.

There's no need for GDAL to have boost as dependency. With the GDAL variant (and port) libkml, which does have boost as dependency, however, GDAL's libkml-driver hooks to the libkml API (which in turn does, correctly, include boost API). libkml know where to look for boost header files, but GDAL doesn't. This would be all good and fine if they were located in "standard" location for include files (i.e. ${prefix}/include) .

If the libkml port uses boost then it should probably specify in that port where the boost headers are and gdal should be able to use those - or am I missing something here?

The boost PG defines the version used and ultimately the location of the include files. This is the reason, the only solution I could come up with, was the present by adding the boost PG to GDAL variant libkml. Note this only affects GDAL with the libkml variant. If there is a way to get the include path to boost, from boost PG, without adding the PG to GDAL, that would be an alternative and perhaps better solution.

In short: if it is possible to get:

macports-ports/_resources/port1.0/group/boost-1.0.tcl

Line 52 in 7d3cdee

proc boost::include_dir {} {

without adding boost PG to gdal+libkml, then that would likely be enough.

ryandesign · 2023-04-21T10:48:56Z

When I installed on my system in trace mode (sudo port -t install), it reported a lot of files provided by ports that were not declared as dependencies that the build would have accessed if I had not used trace mode:

  /opt/local/include/H5Cpp.h
  /opt/local/include/OpenEXR/ImfVersion.h
  /opt/local/include/bsoncxx/v_noabi/bsoncxx/config/version.hpp
  /opt/local/include/hdf5.h
  /opt/local/include/json-c/json.h
  /opt/local/include/libheif/heif.h
  /opt/local/include/mongocxx/v_noabi/mongocxx/client.hpp
  /opt/local/include/msodbcsql.h
  /opt/local/include/openjpeg-2.5/opj_config.h
  /opt/local/include/pcre.h
  /opt/local/include/pcre2.h
  /opt/local/include/sql.h
  /opt/local/lib/cmake/json-c/json-c-config.cmake
  /opt/local/lib/oracle/sdk/include/oci.h
  /opt/local/lib/pkgconfig/OpenEXR.pc
  /opt/local/lib/pkgconfig/json-c.pc
  /opt/local/lib/pkgconfig/libheif.pc
  /opt/local/lib/pkgconfig/libmongocxx.pc
  /opt/local/lib/pkgconfig/libopenjp2.pc

Often this indicates that opportunistic linking will occur, which we don't want, and if so the build should be changed so that it doesn't access those files unless it declares dependencies on those ports.

gdal 3.4.3 installed libgdal.30.dylib while gdal 3.6.3 installs libgdal.32.dylib so all ports that link with the library will be broken by this update and need to be rebuilt (via a version update or a revision increase) to avoid that. Here's the list of all ports that mention a gdal dependency though I don't know if all of them link with the library:

% port file all|sort -u|xargs grep -i ':gdal\b'
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/databases/postgis2/Portfile:    depends_lib-append      port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/databases/postgis3/Portfile:    depends_lib-append      port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/gdal-grass/Portfile:depends_lib         port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/grass/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/grass7/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/kealib/Portfile:depends_lib-append  port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/liblas/Portfile:depends_lib-append  port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/libosmium/Portfile:                        port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/mapnik/Portfile:    depends_lib-append      port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/mapserver/Portfile:    depends_lib-append      port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/mapserver/Portfile:    depends_lib-append      port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/orfeotoolbox/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/pdal/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/qgis3/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/qlandkartegt/Portfile:depends_lib      port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/rsgislib/Portfile:depends_lib-append  port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/saga/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/gis/t-rex/Portfile:    port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/OpenSceneGraph-devel/Portfile:                        port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/OpenSceneGraph/Portfile:                        port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/opencv3-devel/Portfile:                            port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/opencv3/Portfile:                            port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/opencv4-devel/Portfile:                    port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/opencv4/Portfile:                    port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/octave/octave-mapping/Portfile:depends_lib-append  port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/python/py-fiona/Portfile:                        port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/python/py-gdal/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/python/py-rasterio/Portfile:                        port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/science/gerbil/Portfile:                    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/science/gmt4/Portfile:    depends_lib-append      port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/science/gmt5/Portfile:    depends_lib-append      port:gdal
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/science/ncarg/Portfile:                            port:gdal       \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/science/sumo/Portfile:    port:gdal \
/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/science/xastir/Portfile:                    port:gdal \

reneeotten · 2023-04-21T11:03:46Z

thanks @ryandesign for pointing that out! Unfortunately trace-mode is still broken on newer OSes so it's hard to test this locally for many people. There are also several Trac tickets for this port that I don't know if they have been resolved. Again, that's really the job of the maintainer of this port.

This PR updates the port and doesn't break it more than it is in the current state.
So yes, ideally everything would be fixed before merging - but at some point we probably just have to merge it and fix other issues step-by-step.

Dave-Allured · 2023-04-21T16:54:28Z

Please update this PR from GDAL 3.6.3 to 3.6.4, a bug fix release on 2023 Apr 21. Thanks.

nilason · 2023-04-22T19:32:48Z

thanks @ryandesign for pointing that out! Unfortunately trace-mode is still broken on newer OSes so it's hard to test this locally for many people. There are also several Trac tickets for this port that I don't know if they have been resolved. Again, that's really the job of the maintainer of this port.

@ryandesign Thanks again for looking at this! Even though I regularly use port -vst I have not seen something similar to what you listed. I do check what drivers are enabled and not, and whether the related port is enabled or not. There are sooo many of them so I cannot guarantee there aren't mismatches, but I general it should be ok. I guess cmake does check up on them (causing the trace), but if not explicitly told to be included they will be disabled.

This PR updates the port and doesn't break it more than it is in the current state. So yes, ideally everything would be fixed before merging - but at some point we probably just have to merge it and fix other issues step-by-step.

I agree. I will make the bump to 3.6.4 (thanks @Dave-Allured!), and when there is an agreement on the boost issue, I'll add a dependencies-revision-bump-commit.

Dave-Allured · 2023-04-23T03:23:11Z

@ryandesign said:

When I installed on my system in trace mode (sudo port -t install), it reported a lot of files provided by ports that were not declared as dependencies that the build would have accessed if I had not used trace mode:

... Often this indicates that opportunistic linking will occur, which we don't want, and if so the build should be changed so that it doesn't access those files unless it declares dependencies on those ports.

Ryan, this seems like false positives. I tested this with a default Macports build of GDAL 3.6.3, with custom prefix and no sudo privs. It built fine, other dependencies were installed, there were no complaints, and none of those 19 reported files were installed by anything. By name I associated 9 files out of 19 with inactive variants in @nilason's port file:

/opt/local/include/H5Cpp.h
/opt/local/include/hdf5.h
-DGDAL_USE_HDF5=OFF

/opt/local/include/OpenEXR/ImfVersion.h
/opt/local/lib/pkgconfig/OpenEXR.pc
-DGDAL_USE_OPENEXR=OFF

/opt/local/include/libheif/heif.h
/opt/local/lib/pkgconfig/libheif.pc
-DGDAL_USE_HEIF=OFF

/opt/local/include/openjpeg-2.5/opj_config.h
/opt/local/lib/pkgconfig/libopenjp2.pc
-DGDAL_USE_OPENJPEG=OFF

/opt/local/include/sql.h
-DGDAL_USE_MYSQL=OFF

So what is port install -t really doing here? Testing all variants, or what? Unless I am missing something, it seems that no new dependency declarations are needed for this port.

nilason · 2023-04-24T11:13:41Z

Updated PR to bump to GDAL 3.6.4. Still not sure how to solve the boost issue differently.

nilason · 2023-04-24T19:16:13Z

The commits 41b2884 and f32e5c8 is an alternative to initial PG solution for boost.

py-gdal bumped to 3.6.4 GDAL 3.6.0 dropped support for Autotools and fully transitioned to CMake. The gdal portfile is a major remake accordingly. Variants added: - openexr - postgresql15 - proj9 - cryptopp Variants removed: - jasper - grass (now available as a standalone driver with 'gdal-grass') - mysql5 See https://trac.macports.org/ticket/43431

The "gdal-grass " GDAL driver has been split from GDAL and being made a standalone driver at https://github.com/OSGeo/gdal-grass. The version numbering is now separate from GDAL version and (re-)started from 1.0 (hence necessitated the setting of epoch). Variants added: - postgresql11-postgresql15 - grass Variants removed: - grass7 GRASS version detection is now done at build time. Closes: https://trac.macports.org/ticket/64411

nilason · 2023-04-25T10:19:21Z

I believe this is ready for merge.
My solution for the boost problem was a minor patch to the libkml pc-file.

nilason · 2023-04-28T18:43:29Z

#18418 should preferably be merged before this.

nilason · 2023-04-28T19:58:18Z

If there are no more objections, suggestions, this may be merged now.
More than a whole year since last version bump of this port, now being very outdated, and a month since I put up this PR...

i0ntempest · 2023-04-28T20:37:04Z

Are those failing checks just timeouts? If so I'll merge in 24 hours if no one objects.

reneeotten · 2023-04-28T21:23:29Z

Are those failing checks just timeouts? If so I'll merge in 24 hours if no one objects.

You haven't commented or reviewed anything on this PR; so I'd suggest you leave merging of this to the people who did and can verify whether the comments have indeed been addressed.

i0ntempest · 2023-04-28T21:27:48Z

Are those failing checks just timeouts? If so I'll merge in 24 hours if no one objects.

You haven't commented or reviewed anything on this PR; so I'd suggest you leave merging of this to the people who did and can verify whether the comments have indeed been addressed.

Cool, I won't touch this then. Just wanted to speed things up a bit since as the author said it's been a month ¯_(ツ)_/¯

reneeotten · 2023-04-30T18:30:51Z

thanks @nilason for all your work on this! I revisited the PR and it seems all good to me, so I'll merge now and if issues show up we can address them!

PS if you're interested in helping to maintain and update these ports, you could consider adding yourself as co-maintainer as @Veence has been rather absent lately.

nilason · 2023-05-02T14:25:21Z

thanks @nilason for all your work on this! I revisited the PR and it seems all good to me, so I'll merge now and if issues show up we can address them!

Thank you all for getting this/these through!

PS if you're interested in helping to maintain and update these ports, you could consider adding yourself as co-maintainer as @Veence has been rather absent lately.

I've been thinking on this some time, unburden Veence in busy periods. What is the procedure for this?

reneeotten · 2023-05-03T01:02:29Z

you can open a PR that adds yourself as a co-maintainer, if @Veence agrees with that (or doesn't respond in a reasonable amount of time) we can just merge it and move on. A slightly more drastic measure would be to file a "Port abandoned" ticket.

macportsbot assigned Veence and petrrr Mar 24, 2023

macportsbot added type: update maintainer: open Affects an openmaintainer port labels Mar 24, 2023

nilason force-pushed the gdal_update_3.6.3 branch 2 times, most recently from f0500e4 to 7757cdc Compare March 25, 2023 21:29

ryandesign reviewed Mar 28, 2023

View reviewed changes

nilason force-pushed the gdal_update_3.6.3 branch 2 times, most recently from bdb41b2 to 099c88c Compare March 28, 2023 19:20

nilason commented Apr 15, 2023

View reviewed changes

nilason commented Apr 17, 2023

View reviewed changes

nilason force-pushed the gdal_update_3.6.3 branch 2 times, most recently from 22b63fa to c1c1566 Compare April 20, 2023 11:48

nilason commented Apr 20, 2023

View reviewed changes

nilason mentioned this pull request Apr 21, 2023

qgis3: Update to 3.28.6 with new PROJ and GRASS variants #18253

Merged

12 tasks

nilason force-pushed the gdal_update_3.6.3 branch from c1c1566 to 4150e98 Compare April 24, 2023 11:09

nilason changed the title ~~gdal: update to 3.6.3~~ gdal: update to 3.6.4 Apr 24, 2023

nilason added 4 commits April 25, 2023 11:09

liblas: minor version bump and add proj9

3875595

libkml: patch libkml.pc to add boost include dir

fbe0956

nilason force-pushed the gdal_update_3.6.3 branch from f32e5c8 to fbe0956 Compare April 25, 2023 09:13

gdal dependents: rev-bump for update

13d4d68

nilason mentioned this pull request Apr 28, 2023

spatialite, spatialite-tools : add proj9 variants #18418

Merged

11 tasks

reneeotten merged commit 3d95877 into macports:master Apr 30, 2023
0 of 2 checks passed

nilason deleted the gdal_update_3.6.3 branch May 2, 2023 06:42

nilason mentioned this pull request Sep 8, 2023

leveldb: expose memenv #20338

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gdal: update to 3.6.4 #18077

gdal: update to 3.6.4 #18077

nilason commented Mar 24, 2023 •

edited

macportsbot commented Mar 24, 2023

nilason commented Mar 26, 2023

nilason commented Mar 26, 2023

ryandesign left a comment

nilason commented Mar 28, 2023

nilason commented Mar 28, 2023

nilason commented Mar 31, 2023

nilason commented Apr 3, 2023

nilason Apr 15, 2023

nilason Apr 17, 2023

nilason Apr 20, 2023

reneeotten Apr 21, 2023

nilason Apr 21, 2023

nilason Apr 21, 2023

reneeotten Apr 22, 2023

nilason Apr 22, 2023

nilason Apr 23, 2023

ryandesign commented Apr 21, 2023

reneeotten commented Apr 21, 2023

Dave-Allured commented Apr 21, 2023

nilason commented Apr 22, 2023

Dave-Allured commented Apr 23, 2023

nilason commented Apr 24, 2023

nilason commented Apr 24, 2023

nilason commented Apr 25, 2023

nilason commented Apr 28, 2023

nilason commented Apr 28, 2023

i0ntempest commented Apr 28, 2023

reneeotten commented Apr 28, 2023

i0ntempest commented Apr 28, 2023

reneeotten commented Apr 30, 2023

nilason commented May 2, 2023

reneeotten commented May 3, 2023

gdal: update to 3.6.4 #18077

gdal: update to 3.6.4 #18077

Conversation

nilason commented Mar 24, 2023 • edited

Description

Type(s)

Tested on

Verification

macportsbot commented Mar 24, 2023

nilason commented Mar 26, 2023

nilason commented Mar 26, 2023

ryandesign left a comment

Choose a reason for hiding this comment

nilason commented Mar 28, 2023

nilason commented Mar 28, 2023

nilason commented Mar 31, 2023

nilason commented Apr 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryandesign commented Apr 21, 2023

reneeotten commented Apr 21, 2023

Dave-Allured commented Apr 21, 2023

nilason commented Apr 22, 2023

Dave-Allured commented Apr 23, 2023

nilason commented Apr 24, 2023

nilason commented Apr 24, 2023

nilason commented Apr 25, 2023

nilason commented Apr 28, 2023

nilason commented Apr 28, 2023

i0ntempest commented Apr 28, 2023

reneeotten commented Apr 28, 2023

i0ntempest commented Apr 28, 2023

reneeotten commented Apr 30, 2023

nilason commented May 2, 2023

reneeotten commented May 3, 2023

nilason commented Mar 24, 2023 •

edited