Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3-devel: update to 3.24.37, including migration to Meson #18385

Merged
merged 1 commit into from Apr 24, 2023
Merged

gtk3-devel: update to 3.24.37, including migration to Meson #18385

merged 1 commit into from Apr 24, 2023

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Apr 23, 2023 •
edited

Description

  • Update gtk3-devel to 3.24.37
  • Migrate to Meson, as autotools is no longer supported with this release
  • While the quartz variant builds fine, x11 does not.
  • Submitting this PR both to see whether it's a potential local issue, as well as for feedback from @lukaso, @kencu, and any other gtk-savvy folks.

Fixes:

@mascguy mascguy requested a review from kencu April 23, 2023 15:19
@macportsbot macportsbot added type: update maintainer maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Apr 23, 2023
@mascguy mascguy requested a review from ctreleaven April 23, 2023 17:41
@mascguy
Copy link
Member Author

mascguy commented Apr 23, 2023 •
edited

Ah, there was one critical piece I missed: Upstream's meson.build is forcibly disabling X11 for macOS, and we have to override that behavior.

But the solution was provided by @ctreleaven, via ticket 66487 - gtk3 menues broken with macos ventura - update needed.

@mascguy
Copy link
Member Author

mascguy commented Apr 23, 2023

One final note: I'm still reviewing the dependencies - both for X11, as well as in-general - as I added several that may not be needed. More to follow.

@MStraeten MStraeten mentioned this pull request Apr 24, 2023
Closed
@mascguy mascguy marked this pull request as ready for review April 24, 2023 14:40
@mascguy
Copy link
Member Author

mascguy commented Apr 24, 2023

While we may prune the dependencies at some point, I'm good with releasing this as-is. Once it builds across-the-board, I'll update gtk3 as well.

@mascguy mascguy merged commit 4a78710 into macports:master Apr 24, 2023
2 checks passed
@mascguy mascguy deleted the mascguy-gtk3-devel branch April 24, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kencu kencu Awaiting requested review from kencu

@ctreleaven ctreleaven Awaiting requested review from ctreleaven

Assignees
No one assigned
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: update
Milestone
No milestone
2 participants
@mascguy @macportsbot