cpuid: blacklist old gcc, fixes build on macOS <10.6 #18629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc <=4.2 doesn't support the options used in the Makefile, or the 'asm' statement used for the cpuid instruction. Fixes: https://trac.macports.org/ticket/67395
|
Notifying maintainers: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gcc <=4.2 doesn't support the options used in the Makefile, or the 'asm' statement used for the cpuid instruction.
Fixes: https://trac.macports.org/ticket/67395
Type(s)
Tested on
macOS 10.4.8 8L2127 i386
Component versions: DevToolsCore-798.0; DevToolsSupport-794.0
macOS 10.5.8 9L30 i386
Xcode 3.1.4 9M2809
Verification
Have you
port lint --nitpick?sudo port -vst install?