icu-devel: fix build on Tiger

[evanmiller]

Description

The icu 73.1 update does not build on Tiger due to the --enable-rpath flag that is passed. But with --disable-rpath, the build is broken due to an incorrect install_name.

No rev-bump needed since the compile fails.

See: https://trac.macports.org/ticket/67433
See: https://trac.macports.org/ticket/67428

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@catap for port icu-devel.

[catap]

@evanmiller I really don't understand this patch because --enable-rpath and --disable-rpath only control the condition you broke.

Differences between --enable-rpath and --disable-rpath with your patch shouldn't be noticeable at all.

[catap]

See: #18392 (comment)

[evanmiller]

@catap --enable-rpath causes -Wl,-rpath to be passed. This causes a failed build on Tiger.

https://github.com/unicode-org/icu/blob/ba1c7006b7b5acd734538b9997102d7f46203576/icu4c/source/config/Makefile.inc.in#L62

[evanmiller]

See: https://trac.macports.org/ticket/67428#comment:5

[catap]

I see.

maybe backport it to upstream isn’t so bad idea, is it?

[catap]

@evanmiller would you like to backport it to upstream? :)

[evanmiller]

Per @kencu's suggestion I have updated the patch to 1) fix rpath installs 2) fix no-rpath installs and 3) disable rpath for MacPorts. This gives us a patch that we can send upstream.

[catap]

I not sure about (3); I think that using rpath isn't bad if it works :)

I'll take closer look to this PR in the next few days.

[kencu]

macports has a policy/strong preference to not use rpaths unless there is no option, as it is too hard to debug issues. Almost all users and most devs have no clue how to be certain what libraries are really being used when rpaths are involved.

It’s best to configure all systems the same if possible

fixing the rpaths option in icu is a good thing, thanks Evan

[catap]

After some additional thinking I'd like to agree that @rpath here makes things more complicated. Let keep it disabled.

@kencu may I ask you to merge this PR? It seems as ready as it can be :)

[catap]

@evanmiller may you also bump a revision?

[mascguy]

@evanmiller may you also bump a revision?

Okay, we'll wait to merge then.

[evanmiller]

@evanmiller may you also bump a revision?

done

[mascguy]

LGTM

[kencu]

well done all, and thanks for the upstream PR too.

[mascguy]

well done all, and thanks for the upstream PR too.

Yep, agreed!