Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal: add +libarchive variant #18730

Merged
merged 1 commit into from May 18, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented May 18, 2023

Description

Add dependency and linking to libarchive with a new +libarchive variant and thus prevent opportunistic linking.

Closes: https://trac.macports.org/ticket/67448

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.6.5 21G531 arm64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

and prevent opportunistic linking.

Closes: https://trac.macports.org/ticket/67448
@macportsbot
Copy link

Notifying maintainers:
@Veence for port gdal.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels May 18, 2023
@mascguy mascguy self-assigned this May 18, 2023
Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Veence ?

@barracuda156 barracuda156 mentioned this pull request May 18, 2023
12 tasks
@nilason
Copy link
Contributor Author

nilason commented May 18, 2023

LGTM. @Veence ?

Absolutely no disrespect for Veence, but considering the negative effect on quite a number of dependencies and Veence's absence lately, I think we should proceed with this PR ASAP.

@mascguy
Copy link
Member

mascguy commented May 18, 2023

LGTM. @Veence ?

Absolutely no disrespect for Veence, but considering the negative effect on quite a number of dependencies and Veence's absence lately, I think we should proceed with this PR ASAP.

Agreed, I'll go ahead and merge.

@mascguy mascguy merged commit 076c280 into macports:master May 18, 2023
3 checks passed
@nilason
Copy link
Contributor Author

nilason commented May 18, 2023

LGTM. @Veence ?

Absolutely no disrespect for Veence, but considering the negative effect on quite a number of dependencies and Veence's absence lately, I think we should proceed with this PR ASAP.

Agreed, I'll go ahead and merge.

Great!

As @ryandesign mentioned in the trac ticket:

After that, we should force buildbot builds of all ports that depend on gdal.

How and who can manage that?

@mascguy
Copy link
Member

mascguy commented May 18, 2023

Great!

As @ryandesign mentioned in the trac ticket:

After that, we should force buildbot builds of all ports that depend on gdal.

How and who can manage that?

I'll take care of that now. Thanks for the heads-up!

@nilason nilason deleted the gdal_add_libarchive_variant branch May 22, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
4 participants