Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf5: 1.14.1-2 #18775

Merged
merged 4 commits into from
May 26, 2023
Merged

hdf5: 1.14.1-2 #18775

merged 4 commits into from
May 26, 2023

Conversation

eborisch
Copy link
Member

Maintainer update & bumps.

Tried to tag those with multiple ports impacted.

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port deal.ii, octave, cgnslib, gmsh, libmed, xdmf.
@neurodroid for port py-stfio.
@mtorrent for port abinit.
@jswoboda for port digital_rf.
@lpsinger for port lal.
@barracuda156 for port R-HDF5Array, R-rhdf5, R-rhdf5filters.
@stromnov for port InsightToolkit-devel, vtk, shogun-devel.
@egull for port ALPSMaxent.
@ryanvolz for port digital_rf.
@remkos for port nco.
@mf2k for port ncpp.
@tenomoto for port gnudatalanguage, cdo, grads, hdfeos5, magicspp, metview, nco, netcdf, wgrib2.
@petrrr for port py-nio.
@galexv for port ALPSCore.
@ra1nb0w for port AppCSXCAD, openEMS, CSXCAD.
@jjstickel for port paraview.
@rdbisme for port vtk.
@jswhit for port py-netcdf4.
@Schamschula for port mathgl, armadillo.
@johndesanto for port gmtsar.
@dstrubbe for port paraview.
@BSeppke for port vigra.
@jcupitt for port vips.

@macportsbot macportsbot added maintainer: requires approval by: member Created by a member with commit rights labels May 22, 2023
@Schamschula
Copy link
Contributor

Schamschula commented May 22, 2023

Both armadillo and mathgl have a clean build.

I did see the following for hdf5:

Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled:
strchr: found in hdf5-1.14.1-2/config.log

@barracuda156
Copy link
Contributor

@eborisch Is it possible to address this along? https://trac.macports.org/ticket/67273
I need Fortran support in hdf5 for several new ports which otherwise cannot be built.

@eborisch eborisch merged commit 6b3f07b into macports:master May 26, 2023
@eborisch eborisch deleted the hdf5 branch May 26, 2023 13:36
@eborisch
Copy link
Member Author

Both armadillo and mathgl have a clean build.

I did see the following for hdf5:

Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled: strchr: found in hdf5-1.14.1-2/config.log

I think this is OK; it appears to be explicitly testing for how to have clang complain about undeclared functions:

  configure:30930: checking for /usr/bin/clang options needed to detect all undeclared functions
  configure:30960: /usr/bin/clang -c  -std=c99  -Wall -Warray-bounds -Wcast-qual [snip]
  conftest.c:99:8: error: call to undeclared library function 'strchr' with type [snip]
  (void) strchr;
         ^
  conftest.c:99:8: note: include the header <string.h> or explicitly provide a declaration for 'strchr'```

@Schamschula
Copy link
Contributor

Both armadillo and mathgl have a clean build.
I did see the following for hdf5:
Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled: strchr: found in hdf5-1.14.1-2/config.log

I think this is OK; it appears to be explicitly testing for how to have clang complain about undeclared functions:

  configure:30930: checking for /usr/bin/clang options needed to detect all undeclared functions
  configure:30960: /usr/bin/clang -c  -std=c99  -Wall -Warray-bounds -Wcast-qual [snip]
  conftest.c:99:8: error: call to undeclared library function 'strchr' with type [snip]
  (void) strchr;
         ^
  conftest.c:99:8: note: include the header <string.h> or explicitly provide a declaration for 'strchr'```

Then you should add something like

configure.checks.implicit_function_declaration.whitelist-append strchr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: requires approval