Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h4h5tools: fix build on newer systems #18955

Merged
merged 1 commit into from Jun 3, 2023
Merged

h4h5tools: fix build on newer systems #18955

merged 1 commit into from Jun 3, 2023

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Jun 3, 2023

closes: https://trac.macports.org/ticket/62917

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.4 22F66 arm64
Xcode 14.3.1 14E300c

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added type: bugfix maintainer: none by: member Created by a member with commit rights labels Jun 3, 2023
@kencu
Copy link
Contributor Author

kencu commented Jun 3, 2023

I don't use this software at all, but I had a few minutes and the changes in the PR fix the build in a logical fashion.

I can't find the upstream place to open an issue / PR for these changes, after 5 minutes looking, however.

@kencu kencu merged commit 7b03a9b into macports:master Jun 3, 2023
3 checks passed
@kencu kencu deleted the h4h5toolsfix branch June 3, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
by: member Created by a member with commit rights maintainer: none type: bugfix
Milestone
No milestone
2 participants
@kencu @macportsbot