gdal: fix opportunistic linking to pcre2

[nilason]

Description

Closes: https://trac.macports.org/ticket/67596

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 12.6.6 21G646 arm64
Xcode 14.2 14C18

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@Veence for port gdal.

[catap]

@nilason this port has a lot of variants to enable different features. May you add one more for pcre?

[nilason]

@nilason this port has a lot of variants to enable different features. May you add one more for pcre?

I did consider it and I wouldn't object too much either. I'm not absolutely positive though, that it will make any difference with sqlite3 not using it (see https://gdal.org/development/building_from_source.html#pcre2).

[nilason]

Let's investigate this a bit better. Perhaps adding pcre2 as a dependent would be preferable to yet another variant.

[nilason]

In linux world there is a package called sqlite3-pcre.

[nilason]

In linux world there is a package called sqlite3-pcre.

A small sqlite extension located at http://git.altlinux.org/people/at/packages/?p=sqlite3-pcre.git

[catap]

@nilason seems like a trivial additional to your update? :)

[nilason]

@nilason seems like a trivial additional to your update? :)

Couldn't resist the challenge, ended up with #19094. However, after finishing that one, I took a closer look at GDAL source. The SQLite extension code needed is already included! I changed this PR to add pcre2 as a dependency.

(#19094 still is useful for general sqlite and spatialite use).

[nilason]

@Veence ?