Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softhsm: fix segment violation at application end #19190

Merged
merged 1 commit into from Jul 1, 2023

Conversation

iay
Copy link
Contributor

@iay iay commented Jun 21, 2023

Fix a segmentation violation at application termination through a combination of a couple of commits cherry-picked from upstream post-2.6.1 and a contribution from mouse07410 directed at the same issue.

Closes: https://trac.macports.org/ticket/64036

Description

The SEGV in question has been seen in a couple of circumstances, as mentioned in the ticket. One is in the face of multiple OpenSSL engines and the other is through use of the PKCS11 bridge from Java. This has been largely fixed upstream (although this includes an additional contribution which may also help in the first problem case).

I believe the issue wasn't always apparent, but appeared when some changes were made to the underlying OpenSSL implementation.

There seems little chance that the upstream project will see another release soon, or perhaps ever. This patch gets the MacPorts version back to functionality; the only alternative for users would be to build from the upstream development branch sources themselves.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.4 22F66 x86_64
Xcode 14.3.1 14E300c

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Fix a segmentation violation at application termination
through a combination of a couple of commits cherry-picked
from upstream post-2.6.1 and a contribution from mouse07410
directed at the same issue.

Closes: https://trac.macports.org/ticket/64036
@macportsbot
Copy link

Notifying maintainers:
@Jakker for port softhsm.

@raimue raimue merged commit f63b8bb into macports:master Jul 1, 2023
3 checks passed
@raimue
Copy link
Member

raimue commented Jul 1, 2023

Merging on behalf of the maintainer without testing. The changes look reasonable and address an active issue with the port in its current state.

@iay iay deleted the 64036-softhsm-segv branch July 3, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants