Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsdl2: patch to revert upstream fix for sdl issue 6948 #19207

Merged
merged 1 commit into from Jun 26, 2023

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Jun 23, 2023

Description

@macportsbot
Copy link

Notifying maintainers:
@jmroot for port libsdl2.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jun 23, 2023
@mascguy
Copy link
Member Author

mascguy commented Jun 23, 2023

Josh, this is just a quick-and-dirty revert. But I suppose a better approach would be to re-add the macOS version checks [with the new code]...?

Up to you, let me know how you'd like to handle this.

@mascguy
Copy link
Member Author

mascguy commented Jun 26, 2023

Maintainer timeout, merging.

@mascguy mascguy merged commit 5a4c116 into macports:master Jun 26, 2023
3 checks passed
@mascguy mascguy deleted the mascguy-libsdl2 branch June 26, 2023 12:55
@jmroot
Copy link
Member

jmroot commented Jun 26, 2023

Josh, this is just a quick-and-dirty revert. But I suppose a better approach would be to re-add the macOS version checks [with the new code]...?

Yes, it would be preferable to put together something that could be accepted upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
3 participants