Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocp: new port @0.2.105 #19395

Merged
merged 3 commits into from
Jul 11, 2023
Merged

ocp: new port @0.2.105 #19395

merged 3 commits into from
Jul 11, 2023

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Jul 9, 2023

Open Cubic Player
closes: https://trac.macports.org/ticket/67733

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.4.1 22F82 arm64
Xcode 14.3.1 14E300c

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added type: submission by: member Created by a member with commit rights labels Jul 9, 2023
@kencu
Copy link
Contributor Author

kencu commented Jul 9, 2023

@ryandesign -- I'll leave this here if you're interested

@ryandesign ryandesign self-assigned this Jul 10, 2023
@barracuda156
Copy link
Contributor

@kencu It does not support libsdl as a fallback, right? (Some currently developed ports still do.)

@kencu
Copy link
Contributor Author

kencu commented Jul 10, 2023

@kencu It does not support libsdl as a fallback, right? (Some currently developed ports still do.)

I believe it can. That might be a nice enhancement for the systems that don’t support libsdl2.

Also sdl is not a hard requirement.

I didn’t try older systems … it uses core audio so there could be issues.

@ryandesign
Copy link
Contributor

I believe it can. That might be a nice enhancement for the systems that don’t support libsdl2.

I'm adding sdl1 and sdl2 variants. Both work for me on Monterey. I think sdl2 works in MacPorts back to Snow Leopard at least but if we need to default to sdl1 on older systems we can.

@barracuda156
Copy link
Contributor

@ryandesign Awesome.

PowerPC presently does not have sdl2 working (incl. Rosetta or 10.6), though I kinda had a semi-functional version based on Ken’s fixes for Intel. I am not sure about 10.6 Intel – if Ken’s fixups were merged, perhaps it works. If not, then unlikely.

For now, if possible, please fallback to sdl1 on all PowerPC and appropriate Intel (not sure about the latter).

@ryandesign
Copy link
Contributor

I am not sure about 10.6 Intel

There is a separate libsdl2-snowleopard port (which the libsdl2 port uses on Snow Leopard and earlier) so I assume at least the intention is that this would work on Snow Leopard and earlier.

@ryandesign ryandesign merged commit a22aba0 into macports:master Jul 11, 2023
3 checks passed
@barracuda156
Copy link
Contributor

I am not sure about 10.6 Intel

There is a separate libsdl2-snowleopard port (which the libsdl2 port uses on Snow Leopard and earlier) so I assume at least the intention is that this would work on Snow Leopard and earlier.

Thank you, I will try it. Somehow missed that one.

@kencu
Copy link
Contributor Author

kencu commented Jul 11, 2023

libsdl2-snowleopard works nicely for SL Intel.

Defaulting MacPorts SnowLeopard support to what SnowLeopard-PowerPC can support would be an unfortunate approach.

@kencu kencu deleted the ocp branch July 11, 2023 13:54
@barracuda156
Copy link
Contributor

libsdl2-snowleopard works nicely for SL Intel.

Defaulting MacPorts SnowLeopard support to what SnowLeopard-PowerPC can support would be an unfortunate approach.

Thankfully, we have arch settings and do not have to coerce every arch to behave identically :)

@kencu
Copy link
Contributor Author

kencu commented Jul 11, 2023

Thankfully, we have arch settings and do not have to coerce every arch to behave identically :)

and yet, look what happened here.

@ryandesign
Copy link
Contributor

It just seemed simpler to set Snow Leopard and earlier to libsdl. Both libsdl and libsdl2 worked for me on Monterey; hopefully libsdl works fine on Snow Leopard. Users can still override the defaults by selecting the other variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights type: submission
4 participants