Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoltenVK: Add subport MoltenVK-1.0.41 #19493

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

Gcenx
Copy link
Contributor

@Gcenx Gcenx commented Jul 18, 2023

Closes https://trac.macports.org/ticket/67759

Description

Type(s)
  • bugfix
Tested on

macOS 14.0 23A5286i x86_64
Xcode 15.0 15A5195m

Verification
  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

[skip notification]

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Jul 18, 2023
Gcenx added a commit to Gcenx/macports-wine that referenced this pull request Jul 23, 2023
Only MoltenVK-latest archives will have the same name so need to be places into versioned directories.
@Gcenx
Copy link
Contributor Author

Gcenx commented Aug 22, 2023

@mascguy could you merge this for me, once we have the 1.0.41 archive on macports mirror I’d like to then force using that over archive.org

The last failure was due to archive.org blocking the traffic.

@jasonliu--
Copy link
Contributor

jasonliu-- commented Aug 22, 2023

... once we have the 1.0.41 archive on macports mirror I’d like to then force using that over archive.org

The last failure was due to archive.org blocking the traffic.

Once the distfile has been downloaded by the MacPorts buildbots and placed into distfiles.macports.org, all future fetches should occur from there, as far as I'm aware. There shouldn't be any need to force using it over archive.org. So if you were thinking that you need to submit another PR to change the master_sites over to distfile.macports.org instead of archive.org, I don't think you do. In fact, it's probably better to keep the archive.org URL, so that we know where the file in distfiles.macports.org came from.

@mascguy
Copy link
Member

mascguy commented Aug 22, 2023

Once the distfile has been downloaded by the MacPorts buildbots and placed into distfiles.macports.org, all future fetches should occur from there, as far as I'm aware. There shouldn't be any need to force using it over archive.org. So if you were thinking that you need to submit another PR to change the master_sites over to distfile.macports.org instead of archive.org, I don't think you do. In fact, it's probably better to keep the archive.org URL, so that we know where the file in distfiles.macports.org came from.

Yep, agreed on all counts.

@Gcenx
Copy link
Contributor Author

Gcenx commented Aug 22, 2023

Ah yeah what I’m saying only applies when the origin archive gets re-released.

I’d have left a note with the original url and just explained why but as the default is obtaining from macports mirrors anyway this should be a none issue

@mascguy mascguy merged commit 5933a13 into macports:master Aug 22, 2023
2 of 3 checks passed
@Gcenx Gcenx deleted the moltenvk-1.0.41 branch August 22, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
4 participants