-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py-graph-tool: Update to version 2.57 #19570
Conversation
Notifying maintainers: |
7476678
to
18c3857
Compare
@@ -115,6 +133,7 @@ if {${name} ne ${subport}} { | |||
destroot.cmd make | |||
destroot.destdir \ | |||
DESTDIR=${destroot} | |||
destroot.target install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't install
the default value for destroot.target
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's overwritten by PG python, so this is necessary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's overwritten by PG python, so this is necessary here.
Well, would it be more accurate to say that this is necessary when python.pep517
is enabled? Which is the default for 3.11 and later.
I'd need to dig into the upstream project a bit, before providing any official recommendations. But if you're working around that by setting destroot.target
, etc, then perhaps it might be better to simply set python.pep517
to no
. (Which might allow you to eliminate at least a few overrides you're setting.)
However, I'll let our more Python-savvy folks chime in with their thoughts and recommendations.
CC: @jmroot
CC: @reneeotten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd need to dig into the upstream project a bit, before providing any official recommendations. But if you're working around that by setting
destroot.target
, etc, then perhaps it might be better to simply setpython.pep517
tono
. (Which might allow you to eliminate at least a few overrides you're setting.)
That being said, I'm not overly concerned, so no need to hold up merging this.
Note: The CI and buildbots will all fail on this port for cc: @mascguy |
I'll try to take a look at a subport approach for 181 soon, as this is definitely a pain... |
@mascguy May we please merge this PR and get a working The |
Presently building the 3.11 subport locally on 10.15 [with trace mode], to see whether all is well. It's taking far longer than expected though. There are also an inordinate number of warnings, enough so to utterly pollute the build log. I may suppress some of them before merging, as they make it difficult to follow the compilation itself... |
Which is probably due to the project Makefile setting |
974bb0e
to
56da46a
Compare
* Add Py 311, Remove Py 37 * Use boost181 * Bugfix for unary_function C++17 removal Fixes: https://trac.macports.org/ticket/67808
p.s. You inadvertently included an update to |
Building a single subport takes a very long time, at least on my older MacPro. So I've only validated Given that there don't appear to be any dependents on this port, it might be worth dropping subports for 3.9 and prior. |
Description
py-graph-tool: Update to version 2.57
* Add 311, Remove 37
* Use boost181
* Bugfix for unary_function C++17 removal
Type(s)
Tested on
macOS 13.4.1 22F770820d arm64
Xcode 14.3.1 14E300c
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?