Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jet: new submission (version 0.6.26) #19615

Merged
merged 1 commit into from
Aug 8, 2023
Merged

jet: new submission (version 0.6.26) #19615

merged 1 commit into from
Aug 8, 2023

Conversation

catap
Copy link
Contributor

@catap catap commented Jul 25, 2023

Description

Jet is a simple CLI utilite to transform between JSON, EDN, YAML and Transit
which is created on Clojure.

Type(s)
  • enhancement
Tested on

macOS 12.6.8 21G725 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Copy link
Contributor

@ryandesign ryandesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this installs architecture-specific files, just a jar file. If you agree, supported_archs noarch should be added.

It doesn't look like the files it installs vary by OS or OS version. If you agree, platforms any should be added.

textproc/jet/Portfile Outdated Show resolved Hide resolved
textproc/jet/Portfile Outdated Show resolved Hide resolved
textproc/jet/Portfile Outdated Show resolved Hide resolved
@catap
Copy link
Contributor Author

catap commented Jul 27, 2023

Ryan thanks for review. Anyway, this port is really install binary which is compiled from .jar by graalvm.

@catap catap requested a review from ryandesign July 27, 2023 10:02
@catap
Copy link
Contributor Author

catap commented Aug 2, 2023

@ryandesign, @herbygillot any thoughts?

@catap
Copy link
Contributor Author

catap commented Aug 5, 2023

@mascguy may I ping you here?

@mascguy mascguy merged commit b37e601 into macports:master Aug 8, 2023
3 checks passed
@catap catap deleted the jet branch August 8, 2023 13:39
@catap
Copy link
Contributor Author

catap commented Aug 8, 2023

Thanks, Christopher!

@mascguy
Copy link
Member

mascguy commented Aug 8, 2023

There's just one issue: Port openjdk17-graalvm fails on all buildbots, preventing jet from building.

It might be related to the case-sensitive filesystem on our buildbots. But definitely fixable:

Error: Failed to activate openjdk17-graalvm:
Image error: /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt
already exists and does not belong to a registered port.

CC: @breun

@breun
Copy link
Member

breun commented Aug 9, 2023

The openjdk17-graalvm port basically just unpacks a .tar.gz file, so I don't understand how it can fail to activate on the buildbots.

It works on my machine, as well as here: https://github.com/macports/macports-ports/pull/19623/checks

I don't know if it's relevant, but /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt should be a symlink to another file in the tarball:

~ ❯ ls -l /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt
lrwxr-xr-x  1 root  admin  31 25 jul 21:33 /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt -> lib/svm/LICENSE_NATIVEIMAGE.txt

@mascguy
Copy link
Member

mascguy commented Aug 9, 2023

The openjdk17-graalvm port basically just unpacks a .tar.gz file, so I don't understand how it can fail to activate on the buildbots.

It works on my machine, as well as here: #19623 (checks)

I don't know if it's relevant, but /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt should be a symlink to another file in the tarball:

~ ❯ ls -l /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt
lrwxr-xr-x  1 root  admin  31 25 jul 21:33 /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt -> lib/svm/LICENSE_NATIVEIMAGE.txt

I specifically use a case-sensitive filesystem for the MacPorts build tree (${prefix}/var/macports/build), and it works fine on my machine as well.

Perhaps this is a known issue, but I'd need to run some Trac searches to say for sure.

If anyone else has any thoughts or insight, feel free to chime in...

@mascguy
Copy link
Member

mascguy commented Aug 9, 2023

The openjdk17-graalvm port basically just unpacks a .tar.gz file, so I don't understand how it can fail to activate on the buildbots.

It works on my machine, as well as here: #19623 (checks)

New ticket created, to track the issue:

67935 - openjdk17-graalvm: buildbot activation fails: file LICENSE_NATIVEIMAGE.txt already exists and does not belong to a registered port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants