Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kerberos5: build with LibreSSL #19799

Closed
wants to merge 1 commit into from
Closed

kerberos5: build with LibreSSL #19799

wants to merge 1 commit into from

Conversation

Zweihorn
Copy link
Contributor

@Zweihorn Zweihorn commented Aug 7, 2023 •
edited

Description

kerberos5 @1.21.1 can be built with LibreSSL again, if we can provide "explicit_bzero", see #66601 trac ticket. However, this requires the new port 'libbsd' and we use subport 'libbsd-devel' until new version from upstream is available.

The new port 'libbsd' with subport 'libbsd-devel' was provided as PR #19785 with the specific purpose of supporting this PR.

Please note there is an older PR #16927 addressing the kerberos5 @1.20 legacy version which seems to be stuck and would be superseeded by this PR.

Please be aware the testing of all binaries was out of scope for my current contribution and should be performed by a long-standing expert person like the official maintainer, I presume.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.7.9 20G1426 x86_64
Xcode 13.0 13A233

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change? (see above)
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files? (see above)
  • checked that the Portfile's most important variants haven't been broken?

@Zweihorn
kerberos5: build with LibreSSL
bf2eda7 
* build kerberos5 @1.21.1 with LibreSSL again
* establishes new variant +libressl
* requires new 'libbsd-devel' port
* includes patch derived from FreeBSD

Fixes: https://trac.macports.org/ticket/66601
@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Aug 7, 2023
@Zweihorn Zweihorn marked this pull request as draft August 7, 2023 19:40
@Zweihorn Zweihorn marked this pull request as ready for review August 7, 2023 20:59
@Zweihorn
Copy link
Contributor Author

Zweihorn commented Aug 7, 2023

@ryandesign as maintainer ...

🌻

@Zweihorn
Copy link
Contributor Author

Zweihorn commented Aug 7, 2023

FYI

We no longer ship with the compatibility functions exported from libcrypto, instead statically linking them in directly, since 3.7.1 or so.

ref libressl/portable#647 (comment)

ryandesign
ryandesign reviewed Aug 10, 2023
View reviewed changes
net/kerberos5/Portfile

patchfiles-append patch-plugins_preauth_pkinit_pkinit__crypto__openssl.c.diff

configure.optflags-append -DLIBBSD_OVERLAY -isystem ${prefix}/include/bsd -L${prefix}/lib -lbsd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configure.optflags is for optimization flags, which none of these are.

@ryandesign
Copy link
Contributor

FYI

We no longer ship with the compatibility functions exported from libcrypto, instead statically linking them in directly, since 3.7.1 or so.

ref libressl/portable#647 (comment)

Right... As I recall, the problems we were experiencing—where software thought explicit_bzero was available when it was not—were caused by libressl exporting that symbol. Since 3.7.1 or so they are no longer exporting that symbol, which should fix the problem. So why would we now still need to provide explicit_bzero via libbsd?

@reneeotten
Copy link
Contributor

@ryandesign do you see a path forward with this PR. If not please close it...

@reneeotten
Copy link
Contributor

if there is patch forward for this PR please do the required work and feel free to re-open

@reneeotten reneeotten closed this Jan 14, 2024
@pmetzger
Copy link
Member

@reneeotten FWIW, I have a suspicion that @ryandesign doesn't see notifications about mentions in discussion threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandesign ryandesign ryandesign left review comments

Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port
Milestone
No milestone
5 participants
@Zweihorn @ryandesign @reneeotten @pmetzger @macportsbot